summaryrefslogtreecommitdiffstats
path: root/core/divelist.h
diff options
context:
space:
mode:
authorGravatar Berthold Stoeger <bstoeger@mail.tuwien.ac.at>2018-06-28 08:04:53 +0200
committerGravatar Lubomir I. Ivanov <neolit123@gmail.com>2018-07-18 02:11:16 +0300
commitb7bb9b417775b6ef69c7c865144d857fd00bb506 (patch)
treefd2fb0d27ed5eef49dc68da5c5cbe0917171d187 /core/divelist.h
parent6d72871942adf03e13436ff9342951543351cea6 (diff)
downloadsubsurface-b7bb9b417775b6ef69c7c865144d857fd00bb506.tar.gz
Bluetooth: don't call deviceDiscoveryError() on scan finished
In the remoteDeviceScanFinished slot, the old code called into the deviceDiscoveryError() in case the device discovery agent had the error flag set. This is not necessary, since the agent will send an error signal in such a case. For Qt's device discovery agent, the whole check-for-error is unnecessary, as the documentation states: "The signal is not going to be emitted if the device discovery finishes with an error." But for the homebrew WinBluetoothDeviceDiscoveryAgent, which derives from QThread, both an error() *and* a finished() signal will be sent. Therefore keep the test, but don't call into the slot twice. Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
Diffstat (limited to 'core/divelist.h')
0 files changed, 0 insertions, 0 deletions