summaryrefslogtreecommitdiffstats
path: root/core/qt-ble.cpp
diff options
context:
space:
mode:
authorGravatar Linus Torvalds <torvalds@linux-foundation.org>2017-06-26 18:17:06 -0700
committerGravatar Dirk Hohndel <dirk@hohndel.org>2017-06-26 22:20:01 -0700
commitd0c3ef4cf88149ccc337b1e7c05625957216d4e1 (patch)
treef4c425556b66fff37f42b036695ec847b4d87254 /core/qt-ble.cpp
parentbbde0a1741fe981a8dfe991e6fa3a740ba9b28ac (diff)
downloadsubsurface-d0c3ef4cf88149ccc337b1e7c05625957216d4e1.tar.gz
Bluetooth: make LE-only devices add "LE:" as an address prefix
This seems a bit odd, but it actually has three different reasons for it: - It's a visual indication of BT LE mode for users - the rfcomm code only works with legacy BT support, and if we scan a device that only does LE, we want the custom serial code to instead automatically fall back on a "emulate serial over LE packets" model. - we want rfcomm to remain the default for devices that do both legacy BT _and_ LE, but we want people to have the ability to override the choice manually. They can now do so by just editing the address field and adding the "LE:" prefix manually, and it automatically gets saved for next time. So while a bit hacky, it's actually a very convenient model that not only works automatically, but allows the manual override. Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
Diffstat (limited to 'core/qt-ble.cpp')
-rw-r--r--core/qt-ble.cpp10
1 files changed, 10 insertions, 0 deletions
diff --git a/core/qt-ble.cpp b/core/qt-ble.cpp
index 7a73c02f9..06adce63a 100644
--- a/core/qt-ble.cpp
+++ b/core/qt-ble.cpp
@@ -121,6 +121,16 @@ dc_status_t BLEObject::read(void* data, size_t size, size_t *actual)
dc_status_t qt_ble_open(dc_custom_io_t *io, dc_context_t *context, const char *devaddr)
{
+ /*
+ * LE-only devices get the "LE:" prepended by the scanning
+ * code, so that the rfcomm code can see they only do LE.
+ *
+ * We just skip that prefix (and it doesn't always exist,
+ * since the device may support both legacy BT and LE).
+ */
+ if (!strncmp(devaddr, "LE:", 3))
+ devaddr += 3;
+
QBluetoothAddress remoteDeviceAddress(devaddr);
// HACK ALERT! Qt 5.9 needs this for proper Bluez operation