diff options
| author |  Berthold Stoeger <bstoeger@mail.tuwien.ac.at> | 2018-01-07 15:42:28 +0100 |
|---|---|---|
| committer |  Lubomir I. Ivanov <neolit123@gmail.com> | 2018-01-11 06:07:13 +0100 |
| commit | 6a07ccbad273cdcbea3f984c5c2e9d1b272aae05 (patch) | |
| tree | d389058bb3a66b0cce63331ce325ad34fee6ff22 /core/save-git.c | |
| parent | e85ecdd9254a8bd222ccb2dfed7d3b3bb96c8294 (diff) | |
| download | subsurface-6a07ccbad273cdcbea3f984c5c2e9d1b272aae05.tar.gz | |
Use helper function empty_string() instead of manual checks
For code consistency, substitute boolean expressions:
s && *s -> !empty_string(s)
s && s[0] -> !empty_string(s)
!s || !*s -> empty_string(s)
!s || !s[0] -> empty_string(s)
Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
Diffstat (limited to 'core/save-git.c')
| -rw-r--r-- | core/save-git.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/core/save-git.c b/core/save-git.c index 6eab07580..287a8bab9 100644 --- a/core/save-git.c +++ b/core/save-git.c @@ -1088,11 +1088,11 @@ static void create_commit_message(struct membuffer *msg, bool create_empty) nr = dive->number; put_format(msg, "dive %d: %s", nr, location); - if (trip && trip->location && *trip->location && strcmp(trip->location, location)) + if (trip && !empty_string(trip->location) && strcmp(trip->location, location)) put_format(msg, " (%s)", trip->location); put_format(msg, "\n"); do { - if (dc->model && *dc->model) { + if (!empty_string(dc->model)) { put_format(msg, "%s%s", sep, dc->model); sep = ", "; } |