diff options
| author |  Robert C. Helling <helling@atdotde.de> | 2019-01-12 10:04:05 +0100 |
|---|---|---|
| committer |  bstoeger <32835590+bstoeger@users.noreply.github.com> | 2019-01-16 02:38:30 +0100 |
| commit | 5f04fecd005f6566f9931ba7b692bd6ca109bc87 (patch) | |
| tree | 95391fc1b57ab0a59f405f31292ecb9d5d6bd467 /core/save-git.c | |
| parent | 2c794348c1060c8f6ce55c598c0a20690c4967f2 (diff) | |
| download | subsurface-5f04fecd005f6566f9931ba7b692bd6ca109bc87.tar.gz | |
Don't allow empty username for git
When no real name is set in /etc/passwd the username ends
up being ",,,". Git does not like that. Actually, only the
part before the first comma is the name, the rest is office
and phone number. We don't want those.
Before we only testing for the username being a NULL pointer.
Reported-by: Keith Grimes
Signed-off-by: Robert C. Helling <helling@atdotde.de>
Diffstat (limited to 'core/save-git.c')
| -rw-r--r-- | core/save-git.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/core/save-git.c b/core/save-git.c index 33c01ab83..67a9cb55b 100644 --- a/core/save-git.c +++ b/core/save-git.c @@ -1034,7 +1034,7 @@ static int get_authorship(git_repository *repo, git_signature **authorp) /* try to fetch the user info from the OS, otherwise use default values. */ struct user_info user = { .name = NULL, .email = NULL }; subsurface_user_info(&user); - if (!user.name) + if (!user.name || !*user.name) user.name = strdup("Subsurface"); if (!user.email) user.email = strdup("subsurface-app-account@subsurface-divelog.org"); |