diff options
| author |  Jeremie Guichard <djebrest@gmail.com> | 2018-04-09 10:09:34 +0200 |
|---|---|---|
| committer |  Dirk Hohndel <dirk@hohndel.org> | 2018-04-09 07:59:51 -0700 |
| commit | 7753352e6210ae69c2a79bdf2387eaca46becc64 (patch) | |
| tree | 88c2594af6ff7c87b7923c7b3625653f3b5d7cfe /core/subsurface-qt | |
| parent | f1830cd44e75ac552e09dfd79f6ec9e0d90f8808 (diff) | |
| download | subsurface-7753352e6210ae69c2a79bdf2387eaca46becc64.tar.gz | |
Change taglist_get_tagstring to support 'unlimited' tag list size
Previous taglist_get_tagstring signature/implementation did not allow
handling of cases where inputted buffer could not contain all tags.
New implementation allocates buffer based on pre-computed size allowing to
insert all tags in the returned string.
Added get_taglist_string in qthelper to handle conversion to QString
Added TestTagList with tests for taglist_get_tagstring
Signed-off-by: Jeremie Guichard <djebrest@gmail.com>
Diffstat (limited to 'core/subsurface-qt')
| -rw-r--r-- | core/subsurface-qt/DiveObjectHelper.cpp | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/core/subsurface-qt/DiveObjectHelper.cpp b/core/subsurface-qt/DiveObjectHelper.cpp index 093451ad3..4c1c66e21 100644 --- a/core/subsurface-qt/DiveObjectHelper.cpp +++ b/core/subsurface-qt/DiveObjectHelper.cpp @@ -192,9 +192,7 @@ QString DiveObjectHelper::notes() const QString DiveObjectHelper::tags() const { - static char buffer[256]; - taglist_get_tagstring(m_dive->tag_list, buffer, 256); - return QString(buffer); + return get_taglist_string(m_dive->tag_list); } QString DiveObjectHelper::gas() const |