diff options
| author |  Berthold Stoeger <bstoeger@mail.tuwien.ac.at> | 2017-11-18 10:03:58 +0100 |
|---|---|---|
| committer |  Lubomir I. Ivanov <neolit123@gmail.com> | 2017-11-22 19:22:14 +0100 |
| commit | 7a99d7e5c3b297b543a9ce1ab36e337c1a8e0bf0 (patch) | |
| tree | c9970f32021491a4041a54dd41d394a511986359 /core | |
| parent | 4c1a2cc8dc5aa5dea367d57ef3e6233239d926e7 (diff) | |
| download | subsurface-7a99d7e5c3b297b543a9ce1ab36e337c1a8e0bf0.tar.gz | |
Copy default filename string when assigning to default preferences
This tries to remove subtle ownership issues. When copying preferences
structures, the default filename is copied. But the default preferences
struct simply takes a pointer to a global string which is free()d in main().
Now, this is not strictly a bug because the free()ing of preferences
resources is not implemented. Yet, let's try to make this consistent.
Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
Diffstat (limited to 'core')
| -rw-r--r-- | core/subsurfacestartup.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/core/subsurfacestartup.c b/core/subsurfacestartup.c index 61bff87fa..c5962d6c0 100644 --- a/core/subsurfacestartup.c +++ b/core/subsurfacestartup.c @@ -295,7 +295,7 @@ void setup_system_prefs(void) default_prefs.font_size = system_divelist_default_font_size; #if !defined(SUBSURFACE_MOBILE) - default_prefs.default_filename = system_default_filename(); + default_prefs.default_filename = copy_string(system_default_filename()); #endif env = getenv("LC_MEASUREMENT"); if (!env) |