diff options
| author |  Dirk Hohndel <dirk@hohndel.org> | 2019-03-19 08:22:51 -0700 |
|---|---|---|
| committer | Dirk Hohndel <dirk@hohndel.org> | 2019-03-19 09:56:48 -0700 |
| commit | 8e43d2b8d2023f06e79b1a5b5bfc28bd79294925 (patch) | |
| tree | 9a76f381cad875528b0bf0bb7c96fbc62fe1efef /core | |
| parent | c7bb67c5bef01772a9e52dddccfa5f02d91393ff (diff) | |
| download | subsurface-8e43d2b8d2023f06e79b1a5b5bfc28bd79294925.tar.gz | |
Misc: replace some FIXME comments
All these aren't actually things that need fixing, they are observations about
the code.
Given that LGTM.com reports FIXME comments as Alerts, let's change the ones
that aren't about things that need fixing to something more harmless.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
Diffstat (limited to 'core')
| -rw-r--r-- | core/configuredivecomputerthreads.cpp | 8 | ||||
| -rw-r--r-- | core/dive.c | 4 | ||||
| -rw-r--r-- | core/profile.c | 2 |
3 files changed, 7 insertions, 7 deletions
diff --git a/core/configuredivecomputerthreads.cpp b/core/configuredivecomputerthreads.cpp index 7ca00b917..9b9374c58 100644 --- a/core/configuredivecomputerthreads.cpp +++ b/core/configuredivecomputerthreads.cpp @@ -1442,7 +1442,7 @@ static dc_status_t read_ostc_settings(dc_device_t *device, DeviceDetails *m_devi unsigned char data[256] = {}; #ifdef DEBUG_OSTC_CF - // FIXME: how should we report settings not supported back? + // open question: how should we report settings not supported back? unsigned char max_CF = 0; #endif rc = hw_ostc_device_eeprom_read(device, 0, data, sizeof(data)); @@ -1829,7 +1829,7 @@ static dc_status_t write_ostc_settings(dc_device_t *device, DeviceDetails *m_dev else if (gas5.type == 2) data[33] = 5; else - // FIXME: No gas was First? + // odd: No gas was First? // Set gas 1 to first data[33] = 1; @@ -1956,7 +1956,7 @@ static dc_status_t write_ostc_settings(dc_device_t *device, DeviceDetails *m_dev else if (dil5.type == 2) data[115] = 5; else - // FIXME: No first diluent? + // odd: No first diluent? // Set gas 1 to fist data[115] = 1; @@ -2178,7 +2178,7 @@ void WriteSettingsThread::run() } break; case DC_FAMILY_HW_OSTC3: - // FIXME: Is this the best way? + // Is this the best way? if (m_deviceDetails->model == "OSTC 4") rc = write_ostc4_settings(m_data->device, m_deviceDetails, DeviceThread::event_cb, this); else diff --git a/core/dive.c b/core/dive.c index 0d100f37c..c73453a04 100644 --- a/core/dive.c +++ b/core/dive.c @@ -1577,7 +1577,7 @@ static void simplify_dc_pressures(struct divecomputer *dc) } } -/* FIXME! sensor -> cylinder mapping? */ +/* Do we need a sensor -> cylinder mapping? */ static void fixup_start_pressure(struct dive *dive, int idx, pressure_t p) { if (idx >= 0 && idx < MAX_CYLINDERS) { @@ -2366,7 +2366,7 @@ static int match_cylinder(const cylinder_t *cyl, const struct dive *dive, unsign if (different_manual_pressures(cyl, target)) continue; - /* FIXME! Should we check sizes too? */ + /* open question: Should we check sizes too? */ return i; } return -1; diff --git a/core/profile.c b/core/profile.c index eb78b5147..0d568a4fe 100644 --- a/core/profile.c +++ b/core/profile.c @@ -915,7 +915,7 @@ static void setup_gas_sensor_pressure(const struct dive *dive, const struct dive /* calculate DECO STOP / TTS / NDL */ static void calculate_ndl_tts(struct deco_state *ds, const struct dive *dive, struct plot_data *entry, struct gasmix gasmix, double surface_pressure,enum divemode_t divemode) { - /* FIXME: This should be configurable */ + /* should this be configurable? */ /* ascent speed up to first deco stop */ const int ascent_s_per_step = 1; const int ascent_s_per_deco_step = 1; |