summaryrefslogtreecommitdiffstats
path: root/core
diff options
context:
space:
mode:
authorGravatar Dirk Hohndel <dirk@hohndel.org>2019-10-09 10:49:40 -0500
committerGravatar Lubomir I. Ivanov <neolit123@gmail.com>2019-10-09 22:38:29 +0300
commit9c744e401edb1d2fc31c77b4b156f47be06ce367 (patch)
treeb274f1dd27187c2279aaee2e31dd534e29a61f9d /core
parent65ec16e59d7c55ea9857a1b03db838fe2561986a (diff)
downloadsubsurface-9c744e401edb1d2fc31c77b4b156f47be06ce367.tar.gz
Cloud storage: remove outdated certificate hack
The old server certificates where not recognized on some older platform, so we hardcoded the hex digest of the valid certificate and ignored the error. Those certificates have been replaced last week, so there is no point to this hack anymore - also, we should always show the SSL error, not just in verbose mode. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
Diffstat (limited to 'core')
-rw-r--r--core/checkcloudconnection.cpp21
1 files changed, 3 insertions, 18 deletions
diff --git a/core/checkcloudconnection.cpp b/core/checkcloudconnection.cpp
index e8e48d8f6..98b87aef3 100644
--- a/core/checkcloudconnection.cpp
+++ b/core/checkcloudconnection.cpp
@@ -78,24 +78,9 @@ bool CheckCloudConnection::checkServer()
void CheckCloudConnection::sslErrors(const QList<QSslError> &errorList)
{
- if (verbose) {
- qDebug() << "Received error response trying to set up https connection with cloud storage backend:";
- for (QSslError err: errorList) {
- qDebug() << err.errorString();
- }
- }
- QSslConfiguration conf = reply->sslConfiguration();
- QSslCertificate cert = conf.peerCertificate();
- QByteArray hexDigest = cert.digest().toHex();
- if (reply->url().toString().contains(prefs.cloud_base_url) &&
- hexDigest == "13ff44c62996cfa5cd69d6810675490e") {
- if (verbose)
- qDebug() << "Overriding SSL check as I recognize the certificate digest" << hexDigest;
- reply->ignoreSslErrors();
- } else {
- if (verbose)
- qDebug() << "got invalid SSL certificate with hex digest" << hexDigest;
- }
+ qDebug() << "Received error response trying to set up https connection with cloud storage backend:";
+ for (QSslError err: errorList)
+ qDebug() << err.errorString();
}
// helper to be used from C code