summaryrefslogtreecommitdiffstats
path: root/core
diff options
context:
space:
mode:
authorGravatar Berthold Stoeger <bstoeger@mail.tuwien.ac.at>2019-06-08 13:38:31 +0200
committerGravatar Dirk Hohndel <dirk@hohndel.org>2019-06-19 13:11:10 -0700
commit12a13d722a914240bb553e0dad3e182ae371a45a (patch)
treeb84cbd1ec844d3ebc9a7559e54cb8f1d97e6964e /core
parent38ba434966409987e5dfb894c27c8c03168cfdc6 (diff)
downloadsubsurface-12a13d722a914240bb553e0dad3e182ae371a45a.tar.gz
Undo: sort dives by dive_less_than() in signals
In signals dives were sorted by date. This criterion is not be unique. Therefore sort by the dive_less_than() function of the core to avoid any inconsistencies between the Qt-models and the core data. Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
Diffstat (limited to 'core')
-rw-r--r--core/subsurface-qt/DiveListNotifier.h5
1 files changed, 2 insertions, 3 deletions
diff --git a/core/subsurface-qt/DiveListNotifier.h b/core/subsurface-qt/DiveListNotifier.h
index 06cd3f89e..b7334287e 100644
--- a/core/subsurface-qt/DiveListNotifier.h
+++ b/core/subsurface-qt/DiveListNotifier.h
@@ -1,7 +1,6 @@
// SPDX-License-Identifier: GPL-2.0
-// The DiveListNotifier emits signals when the dive-list changes (dives/trips created/deleted/moved/edited)
-// Note that vectors are passed by reference, so this will only work for signals inside the UI thread!
+// The DiveListNotifier emits signals when the dive-list changes (dives/trips/divesites created/deleted/moved/edited)
#ifndef DIVELISTNOTIFIER_H
#define DIVELISTNOTIFIER_H
@@ -48,7 +47,7 @@ signals:
// or the deletion spans multiple trips. But most of the time only dives of a single trip
// will be affected and trips don't overlap, so these considerations are moot.
// Notes:
- // - The dives are always sorted by start-time.
+ // - The dives are always sorted by according to the dives_less_than() function of the core.
// - The "trip" arguments are null for top-level-dives.
void divesAdded(dive_trip *trip, bool addTrip, const QVector<dive *> &dives);
void divesDeleted(dive_trip *trip, bool deleteTrip, const QVector<dive *> &dives);