summaryrefslogtreecommitdiffstats
path: root/desktop-widgets/command.cpp
diff options
context:
space:
mode:
authorGravatar Berthold Stoeger <bstoeger@mail.tuwien.ac.at>2019-05-24 21:17:22 +0200
committerGravatar Dirk Hohndel <dirk@hohndel.org>2019-06-15 11:20:49 -0700
commitf51e402e04bc1f15da7b9e4d4f57a4e4c5c28490 (patch)
treebb642535124892ae64e14b33c35d9242e594cddb /desktop-widgets/command.cpp
parent944a9aed54b7dfdac606f5503578b46f6c0e8235 (diff)
downloadsubsurface-f51e402e04bc1f15da7b9e4d4f57a4e4c5c28490.tar.gz
Undo: only show warning message if dives were actually edited
The multiple-dives-edited message was shown even if the value was not changed. Notably, when tab-flipping through the dive fields. Therefore, changed the execute_edit() function to return zero when no command was executed. For this, return a boolean from the execute() function indicating whether the command was really executed or trashed. Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
Diffstat (limited to 'desktop-widgets/command.cpp')
-rw-r--r--desktop-widgets/command.cpp5
1 files changed, 2 insertions, 3 deletions
diff --git a/desktop-widgets/command.cpp b/desktop-widgets/command.cpp
index 35010b3c3..78f849651 100644
--- a/desktop-widgets/command.cpp
+++ b/desktop-widgets/command.cpp
@@ -148,9 +148,8 @@ void purgeUnusedDiveSites()
// Execute an edit-command and return number of edited dives
static int execute_edit(EditDivesBase *cmd)
{
- int res = cmd->numDives();
- execute(cmd);
- return res;
+ int count = cmd->numDives();
+ return execute(cmd) ? count : 0;
}
// Dive editing related commands