diff options
author | Berthold Stoeger <bstoeger@mail.tuwien.ac.at> | 2018-07-30 09:20:25 +0200 |
---|---|---|
committer | Dirk Hohndel <dirk@hohndel.org> | 2018-10-11 16:22:27 -0700 |
commit | ec7d85835fb26ee9c0a9c780907441c312d7ac3f (patch) | |
tree | 1ecb5231abdc50929ba6ba308c25196eb408c381 /desktop-widgets/command_divelist.h | |
parent | 6ac4ddbeeda5286faacac9633b622dcf298eea7b (diff) | |
download | subsurface-ec7d85835fb26ee9c0a9c780907441c312d7ac3f.tar.gz |
Dive list: implement proper Qt-model semantics for DiveTripModel
Previously, each dive-list modifying function would lead to a
full model reset. Instead, implement proper Qt-model semantics
using beginInsertRows()/endInsertRows(), beginRemoveRows()/
endRemoveRows(), dataChange().
To do so, a DiveListNotifer singleton is generatated, which
broadcasts all changes to the dive-list. Signals are sent by
the commands and received by the DiveTripModel. Signals are
batched by dive-trip. This seems to be an adequate compromise
for the two kinds of list-views (tree and list). In the common
usecase mostly dives of a single trip are affected.
Thus, batching of dives is performed in two positions:
- At command-level to batch by trip
- In DiveTripModel to feed batches of contiguous elements
to Qt's begin*/end*-functions.
This is conceptually simple, but rather complex code. To avoid
repetition of complex loops, the batching is implemented in
templated-functions, which are passed lambda-functions, which
are called for each batch.
Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
Diffstat (limited to 'desktop-widgets/command_divelist.h')
-rw-r--r-- | desktop-widgets/command_divelist.h | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/desktop-widgets/command_divelist.h b/desktop-widgets/command_divelist.h index 8cff4f1ef..e09d3bdc6 100644 --- a/desktop-widgets/command_divelist.h +++ b/desktop-widgets/command_divelist.h @@ -47,10 +47,12 @@ private: bool workToBeDone() override; // For redo - DiveToAdd diveToAdd; + // Note: we use a vector even though we add only a single dive, so + // that we can reuse the multi-dive functions of the other commands. + std::vector<DiveToAdd> divesToAdd; // For undo - dive *diveToRemove; + std::vector<dive *> divesToRemove; }; class DeleteDive : public Base { |