diff options
| author |  Berthold Stoeger <bstoeger@mail.tuwien.ac.at> | 2019-06-23 12:13:25 +0200 |
|---|---|---|
| committer |  bstoeger <32835590+bstoeger@users.noreply.github.com> | 2019-06-23 20:08:46 +0200 |
| commit | 4716c820322dd654e43dc47087866b066b2e5910 (patch) | |
| tree | fe35e14b3da25e8dad84427cf1b0de2f4de86396 /desktop-widgets/command_edit.cpp | |
| parent | e1abf9485cf59f1b8cb79d827fa386af48f095a4 (diff) | |
| download | subsurface-4716c820322dd654e43dc47087866b066b2e5910.tar.gz | |
Cleanup: remove selectionChanged logic from dive-list commands
Since all commands now fully reset the selection, there is no point
in keeping track of whether the selection changed on addition or
removal of dives. This can be done in the function that sets the
selection.
Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
Diffstat (limited to 'desktop-widgets/command_edit.cpp')
| -rw-r--r-- | desktop-widgets/command_edit.cpp | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/desktop-widgets/command_edit.cpp b/desktop-widgets/command_edit.cpp index 5112043d2..df22552e7 100644 --- a/desktop-widgets/command_edit.cpp +++ b/desktop-widgets/command_edit.cpp @@ -99,8 +99,7 @@ void EditBase<T>::undo() DiveField id = fieldId(); emit diveListNotifier.divesChanged(QVector<dive *>::fromStdVector(dives), id); - if (setSelection(selectedDives, current)) - emit diveListNotifier.selectionChanged(); // If the selection changed -> tell the frontend + setSelection(selectedDives, current); } // We have to manually instantiate the constructors of the EditBase class, @@ -539,8 +538,7 @@ void EditTagsBase::undo() DiveField id = fieldId(); emit diveListNotifier.divesChanged(QVector<dive *>::fromStdVector(dives), id); - if (setSelection(selectedDives, current)) - emit diveListNotifier.selectionChanged(); // If the selection changed -> tell the frontend + setSelection(selectedDives, current); } // Undo and redo do the same as just the stored value is exchanged |