diff options
| author |  Berthold Stoeger <bstoeger@mail.tuwien.ac.at> | 2020-05-27 14:13:15 +0200 |
|---|---|---|
| committer |  Dirk Hohndel <dirk@hohndel.org> | 2020-05-27 09:47:35 -0700 |
| commit | 7417f865cd628aa5df78961dc198a9070822ed72 (patch) | |
| tree | 84a4b8232b849748ce937e110134b2fde665d9f6 /desktop-widgets/divelistview.cpp | |
| parent | 25f1bc488f68395390a3a87328b31dfa7deac11c (diff) | |
| download | subsurface-7417f865cd628aa5df78961dc198a9070822ed72.tar.gz | |
cleanup: un-singletonize ShiftTimesDialog
There is no reason that this dialog is a singleton. Since it is modal,
it can be created on demand. Apart from removing superfluous global state,
this simplifies code, because preparing the widget can now be done in
the constructor instead of overriding the showEvent() function.
Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
Diffstat (limited to 'desktop-widgets/divelistview.cpp')
| -rw-r--r-- | desktop-widgets/divelistview.cpp | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/desktop-widgets/divelistview.cpp b/desktop-widgets/divelistview.cpp index 6d41c7ff1..15c6631bf 100644 --- a/desktop-widgets/divelistview.cpp +++ b/desktop-widgets/divelistview.cpp @@ -860,7 +860,8 @@ void DiveListView::contextMenuEvent(QContextMenuEvent *event) void DiveListView::shiftTimes() { - ShiftTimesDialog::instance()->show(); + ShiftTimesDialog dialog(MainWindow::instance()); + dialog.exec(); } void DiveListView::loadImages() |