diff options
author | Berthold Stoeger <bstoeger@mail.tuwien.ac.at> | 2019-09-01 16:38:48 +0200 |
---|---|---|
committer | Dirk Hohndel <dirk@hohndel.org> | 2019-09-06 11:48:47 -0700 |
commit | 7d2fe2b7c6d921bd7628cf1047266e7be9a0f2e4 (patch) | |
tree | 09bec7e432612969b99db5381b9eeef3e4c719f7 /desktop-widgets/locationinformation.cpp | |
parent | 46e120f81a4631e8425839f7b47e1e9a8aaf2a2c (diff) | |
download | subsurface-7d2fe2b7c6d921bd7628cf1047266e7be9a0f2e4.tar.gz |
Cleanup: remove redundant Roles:: qualifier in maplocationmodel.cpp
"Roles" is a C-style enum (i.e. not C++-style enum class). Since that
means that the names spill into the outer namespace, the names
themselves are prefixed with "Role". Nevertheless the code qualified
the names with "Roles::". This is redundant and unnecessary.
Remove this redundancy to show that we understand how the language
works.
Note: we could also transform the enum into an enum class and remove
the "Role" prefix from the names. That would arguably be "cleaner",
but then the enum doesn't auto-convert to/from int, but Qt uses int
to pass the roles to functions. So let's go the simple way that
avoids casting.
Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
Diffstat (limited to 'desktop-widgets/locationinformation.cpp')
0 files changed, 0 insertions, 0 deletions