diff options
| author |  Berthold Stoeger <bstoeger@mail.tuwien.ac.at> | 2018-10-13 08:57:46 +0200 |
|---|---|---|
| committer |  Dirk Hohndel <dirk@hohndel.org> | 2018-10-13 21:41:41 -0400 |
| commit | 954820aa81cb52cfe4442f2c6e81117827e32ccc (patch) | |
| tree | 5392d9b44ed57542fb60be46a384bf783ed43c59 /desktop-widgets/locationinformation.h | |
| parent | f0e349cdd68c259f07fd5867d8360cd8d65d50ef (diff) | |
| download | subsurface-954820aa81cb52cfe4442f2c6e81117827e32ccc.tar.gz | |
Dive site: explicitly init displayed_dive_site on show widget
The global object "displayed_dive_site" is used to store the
old dive site data for the edit-dive-site widget. The fields
of the widget were initialized from this object in the show
event. Therefore the object was updated in numerous parts of
the code to make sure that it was up-to-date. Instead, move
the initialization of the object to the function that also
initiatlizes the fields. Call this function explicitly before
showing the widget.
This makes the data-fow distinctly easier to understand.
Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
Diffstat (limited to 'desktop-widgets/locationinformation.h')
| -rw-r--r-- | desktop-widgets/locationinformation.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/desktop-widgets/locationinformation.h b/desktop-widgets/locationinformation.h index 868ea729e..402c434e1 100644 --- a/desktop-widgets/locationinformation.h +++ b/desktop-widgets/locationinformation.h @@ -14,9 +14,9 @@ Q_OBJECT public: LocationInformationWidget(QWidget *parent = 0); bool eventFilter(QObject*, QEvent*) override; + void initFields(dive_site *ds); protected: - void showEvent(QShowEvent *); void enableLocationButtons(bool enable); public slots: |