On failed cloud save hide progress bar

The progressbar was not hidden on failed save to cloud. In return
remove an unnecessary variable on loading from cloud.

Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>

1 files changed, 4 insertions, 6 deletions

diff --git a/desktop-widgets/mainwindow.cpp b/desktop-widgets/mainwindow.cpp
index 12592ece0..680a24fde 100644
--- a/desktop-widgets/mainwindow.cpp
+++ b/desktop-widgets/mainwindow.cpp
@@ -610,8 +610,7 @@ void MainWindow::on_actionCloudstorageopen_triggered()
 
 	showProgressBar();
 	QByteArray fileNamePtr = QFile::encodeName(filename);
-	error = parse_file(fileNamePtr.data());
-	if (!error) {
+	if (!parse_file(fileNamePtr.data())) {
 		set_filename(fileNamePtr.data(), true);
 		setTitle(MWTF_FILENAME);
 	}
@@ -638,11 +637,10 @@ void MainWindow::on_actionCloudstoragesave_triggered()
 		information()->acceptChanges();
 
 	showProgressBar();
-
-	if (save_dives(filename.toUtf8().data()))
-		return;
-
+	int error = save_dives(filename.toUtf8().data());
 	hideProgressBar();
+	if (error)
+		return;
 
 	set_filename(filename.toUtf8().data(), true);
 	setTitle(MWTF_FILENAME);