diff options
| author |  Berthold Stoeger <bstoeger@mail.tuwien.ac.at> | 2018-10-08 12:57:46 +0200 |
|---|---|---|
| committer |  Dirk Hohndel <dirk@hohndel.org> | 2018-10-11 16:25:32 -0700 |
| commit | 66c5c5f72b82bd07c6222dbf624d6389237a590b (patch) | |
| tree | 8741a3158c0f52dc5790456f70767dbd77e05cdc /desktop-widgets/mapwidget.cpp | |
| parent | ad57871a2cbb03b0880d33184466e052a20dbd1d (diff) | |
| download | subsurface-66c5c5f72b82bd07c6222dbf624d6389237a590b.tar.gz | |
Map: remove LocationInformationWidget::coordinatesChanged signal
This was used by LocationInformationWidget to instruct the map
that the coordinates of the current dive site has changed.
There is no reason why this couldn't be a function call, as no
other object ever connect()s to this signal. In fact, such a
function already exists viz. updateLocationOnMap.
Therefore, replace the signal by a simple function call.
Moreover, the uuid and coordinates of the dive site were transported
via the global "displayed_dive_site" object. Instead, pass this
information in the parameters of the function. This makes it
easier to reason about data- and control-flow.
Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
Diffstat (limited to 'desktop-widgets/mapwidget.cpp')
| -rw-r--r-- | desktop-widgets/mapwidget.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/desktop-widgets/mapwidget.cpp b/desktop-widgets/mapwidget.cpp index a940cdb39..2966401d2 100644 --- a/desktop-widgets/mapwidget.cpp +++ b/desktop-widgets/mapwidget.cpp @@ -122,10 +122,10 @@ void MapWidget::coordinatesChangedLocal() emit coordinatesChanged(); } -void MapWidget::updateCurrentDiveSiteCoordinatesToMap() +void MapWidget::updateDiveSiteCoordinates(uint32_t uuid, degrees_t latitude, degrees_t longitude) { CHECK_IS_READY_RETURN_VOID(); - m_mapHelper->updateCurrentDiveSiteCoordinatesToMap(); + m_mapHelper->updateDiveSiteCoordinates(uuid, latitude, longitude); } MapWidget::~MapWidget() |