summaryrefslogtreecommitdiffstats
path: root/desktop-widgets/subsurfacewebservices.h
diff options
context:
space:
mode:
authorGravatar Berthold Stoeger <bstoeger@mail.tuwien.ac.at>2018-09-29 22:47:19 +0200
committerGravatar Dirk Hohndel <dirk@hohndel.org>2018-09-29 15:16:11 -0700
commit7c22e4d805f3ae23938fdfedcb02e53d26966dfd (patch)
tree9c07004707b10d2080e608901f53966a80112cc8 /desktop-widgets/subsurfacewebservices.h
parent7c320854b3328be3ba1bfe65adfc118d4e2313d1 (diff)
downloadsubsurface-7c22e4d805f3ae23938fdfedcb02e53d26966dfd.tar.gz
Cleanup: don't derive UserSurveyServices from WebServices
UserSurveyServices derives from WebServices and therefore has to define three pure virtual functions [startDownload(), startUpload(), buttonClicked()] as no-ops. Interestingly, a comment in the header says "need to declare them as no ops or Qt4 is unhappy" which is of course not true as these functions are not declared by Qt. There seems to be no point in deriving from WebServices, therefore don't do it. These function definitions can then be removed. Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
Diffstat (limited to 'desktop-widgets/subsurfacewebservices.h')
-rw-r--r--desktop-widgets/subsurfacewebservices.h8
1 files changed, 1 insertions, 7 deletions
diff --git a/desktop-widgets/subsurfacewebservices.h b/desktop-widgets/subsurfacewebservices.h
index ad68f08f3..b51d81271 100644
--- a/desktop-widgets/subsurfacewebservices.h
+++ b/desktop-widgets/subsurfacewebservices.h
@@ -77,17 +77,11 @@ private:
bool uploadMode;
};
-class UserSurveyServices : public WebServices {
+class UserSurveyServices : public QDialog {
Q_OBJECT
public:
QNetworkReply* sendSurvey(QString values);
explicit UserSurveyServices(QWidget *parent = 0, Qt::WindowFlags f = 0);
-private
-slots:
- // need to declare them as no ops or Qt4 is unhappy
- void startDownload() { }
- void startUpload() { }
- void buttonClicked(QAbstractButton *button) { Q_UNUSED(button) }
};
#endif // SUBSURFACEWEBSERVICES_H