diff options
| author |  Berthold Stoeger <bstoeger@mail.tuwien.ac.at> | 2017-11-18 16:06:41 +0100 |
|---|---|---|
| committer |  Lubomir I. Ivanov <neolit123@gmail.com> | 2017-11-20 20:56:13 +0100 |
| commit | dd8e4fae2aa31f1fac2a8a6f086db0db0a3209c6 (patch) | |
| tree | 5bf0f8872a35f71430733c9766bc70ad65cea499 /desktop-widgets/subsurfacewebservices.h | |
| parent | e762fd2d416cbe77669a83e302709aa3fbda68f7 (diff) | |
| download | subsurface-dd8e4fae2aa31f1fac2a8a6f086db0db0a3209c6.tar.gz | |
Make handling of booleans consistent on the C++-side of preferences
In general, the C++-side of the preferences code consistently uses
the bool data type for boolean settings. There are five exceptions,
which use short instead:
showPo2
showPn2
showPhe
saveUserIdLocal
displayInvalidDives
This patch attempts to make the code more consistent by turning
these into bools as well.
Tests showed that writing as short and reading as bool is handled
gracefully by the Qt variant code. Therefore, an upgrade should not
cause user-visible changes to their settings.
As a bonus, two extern declarations of the set_save_userid_local()
function, which is not defined anywhere, were removed.
Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
Diffstat (limited to 'desktop-widgets/subsurfacewebservices.h')
| -rw-r--r-- | desktop-widgets/subsurfacewebservices.h | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/desktop-widgets/subsurfacewebservices.h b/desktop-widgets/subsurfacewebservices.h index e890bf648..1d4345e7d 100644 --- a/desktop-widgets/subsurfacewebservices.h +++ b/desktop-widgets/subsurfacewebservices.h @@ -113,7 +113,6 @@ slots: #ifdef __cplusplus extern "C" { #endif -extern void set_save_userid_local(short value); extern void set_userid(char *user_id); #ifdef __cplusplus } |