diff options
| author |  Berthold Stoeger <bstoeger@mail.tuwien.ac.at> | 2019-06-23 09:22:26 +0200 |
|---|---|---|
| committer |  bstoeger <32835590+bstoeger@users.noreply.github.com> | 2019-06-23 20:08:46 +0200 |
| commit | 27944a52b1c2a1c68ccfe88c4a84d3f74fb8b512 (patch) | |
| tree | 160fef9677e5cc2e907d4c32448553f74df4d2db /desktop-widgets/tab-widgets/TabDiveInformation.cpp | |
| parent | cbcddaa396f6668fef7750eb2721bc70ca11d0e4 (diff) | |
| download | subsurface-27944a52b1c2a1c68ccfe88c4a84d3f74fb8b512.tar.gz | |
Undo: don't send signals batched by trip
Since the default view is batched by trips, signals were sent trip-wise.
This seemed like a good idea at first, but when more and more parts used
these signals, it became a burden. Therefore push the batching to the
part of the code where it is needed: the trip view.
The divesAdded and divesDeleted are not yet converted, because these
are combined with trip addition/deletion. This should also be detangled,
but not now.
Since the dive-lists were sorted in the processByTrip function, the
dive-list model now does its own sorting. This will have to be
audited.
Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
Diffstat (limited to 'desktop-widgets/tab-widgets/TabDiveInformation.cpp')
| -rw-r--r-- | desktop-widgets/tab-widgets/TabDiveInformation.cpp | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/desktop-widgets/tab-widgets/TabDiveInformation.cpp b/desktop-widgets/tab-widgets/TabDiveInformation.cpp index 589071a5e..9af640a8e 100644 --- a/desktop-widgets/tab-widgets/TabDiveInformation.cpp +++ b/desktop-widgets/tab-widgets/TabDiveInformation.cpp @@ -5,7 +5,6 @@ #include "core/units.h" #include "core/dive.h" #include "desktop-widgets/command.h" -#include "core/trip.h" // TODO: Needed because divesChanged uses a trip parameter -> remove that! #include "core/qthelper.h" #include "core/statistics.h" #include "core/display.h" @@ -131,7 +130,7 @@ void TabDiveInformation::updateData() // This function gets called if a field gets updated by an undo command. // Refresh the corresponding UI field. -void TabDiveInformation::divesChanged(dive_trip *trip, const QVector<dive *> &dives, DiveField field) +void TabDiveInformation::divesChanged(const QVector<dive *> &dives, DiveField field) { // If the current dive is not in list of changed dives, do nothing if (!current_dive || !dives.contains(current_dive)) |