diff options
author | Berthold Stoeger <bstoeger@mail.tuwien.ac.at> | 2019-11-02 22:52:27 +0100 |
---|---|---|
committer | Dirk Hohndel <dirk@hohndel.org> | 2019-12-05 10:14:25 -0800 |
commit | b3253304a59b85c76f8a70f20ada4139e715a5b3 (patch) | |
tree | 8e21ae9d46d9d6ed1f651b7b6008512ae1fd622d /desktop-widgets/tab-widgets/TabDiveSite.h | |
parent | 147a36647ce6148ef2eccbe393faa658d0fe6834 (diff) | |
download | subsurface-b3253304a59b85c76f8a70f20ada4139e715a5b3.tar.gz |
Desktop: don't connect to remove() slot of model from TableModel
When connecting a model to the TableModel class, it would connect
clicking on an item to the remove() slot of the model.
This breaks the program flow implied by the undo code:
Ui --> Undo-Command --> Model --> UI
Moreover, the naming of the remove() slot is illogical, because
clicks can also have different effects, as for example in the
cylinder-table.
Therefore, move the connect() call from TableModel to the
callers. In the case of TabDiveSite, move the remove() function
from the model to the TabWidget, where it makes more sense.
Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
Diffstat (limited to 'desktop-widgets/tab-widgets/TabDiveSite.h')
-rw-r--r-- | desktop-widgets/tab-widgets/TabDiveSite.h | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/desktop-widgets/tab-widgets/TabDiveSite.h b/desktop-widgets/tab-widgets/TabDiveSite.h index 5927b08a0..c5d69eecc 100644 --- a/desktop-widgets/tab-widgets/TabDiveSite.h +++ b/desktop-widgets/tab-widgets/TabDiveSite.h @@ -16,6 +16,7 @@ private slots: void add(); void diveSiteAdded(struct dive_site *, int idx); void diveSiteChanged(struct dive_site *ds, int field); + void diveSiteClicked(const QModelIndex &); void on_purgeUnused_clicked(); void on_filterText_textChanged(const QString &text); void selectionChanged(const QItemSelection &selected, const QItemSelection &deselected); |