diff options
| author |  Jan Mulder <jlmulder@xs4all.nl> | 2018-10-10 14:07:47 +0200 |
|---|---|---|
| committer |  bstoeger <32835590+bstoeger@users.noreply.github.com> | 2018-10-12 13:03:54 +0200 |
| commit | a47df05ce5a94034fd4b5bdd83c8f425e64a5946 (patch) | |
| tree | f1c7704c24843b84b506b8240a0654a758d97f4d /desktop-widgets/tab-widgets/maintab.h | |
| parent | 6137e0bc60691f4b6542cd6bc97fe0106126f728 (diff) | |
| download | subsurface-a47df05ce5a94034fd4b5bdd83c8f425e64a5946.tar.gz | |
Edit: prevent not needed change marking
While trying to understand more of the big change from PR 1528,
I found that the divelist was marked changed while it was not
changed at all. Reason is simple. The MODIFY_DIVES code assumes
its called only for truly changed data. But in case of saving
tagged strings, it was not.
This fixes this. And I do not believe this has any visual effects.
Further, the now broken indentation is fixed seperately.
Signed-off-by: Jan Mulder <jlmulder@xs4all.nl>
Diffstat (limited to 'desktop-widgets/tab-widgets/maintab.h')
| -rw-r--r-- | desktop-widgets/tab-widgets/maintab.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/desktop-widgets/tab-widgets/maintab.h b/desktop-widgets/tab-widgets/maintab.h index c38615c93..d644be4e3 100644 --- a/desktop-widgets/tab-widgets/maintab.h +++ b/desktop-widgets/tab-widgets/maintab.h @@ -119,7 +119,7 @@ private: void copyTagsToDisplayedDive(); void saveTags(const QVector<dive *> &selectedDives); void saveTaggedStrings(const QVector<dive *> &selectedDives); - void diffTaggedStrings(QString currentString, QString displayedString, QStringList &addedList, QStringList &removedList); + int diffTaggedStrings(QString currentString, QString displayedString, QStringList &addedList, QStringList &removedList); void markChangedWidget(QWidget *w); dive_trip_t *currentTrip; dive_trip_t displayedTrip; |