summaryrefslogtreecommitdiffstats
path: root/desktop-widgets/tableview.h
diff options
context:
space:
mode:
authorGravatar Berthold Stoeger <bstoeger@mail.tuwien.ac.at>2019-11-02 22:52:27 +0100
committerGravatar Dirk Hohndel <dirk@hohndel.org>2019-12-05 10:14:25 -0800
commitb3253304a59b85c76f8a70f20ada4139e715a5b3 (patch)
tree8e21ae9d46d9d6ed1f651b7b6008512ae1fd622d /desktop-widgets/tableview.h
parent147a36647ce6148ef2eccbe393faa658d0fe6834 (diff)
downloadsubsurface-b3253304a59b85c76f8a70f20ada4139e715a5b3.tar.gz
Desktop: don't connect to remove() slot of model from TableModel
When connecting a model to the TableModel class, it would connect clicking on an item to the remove() slot of the model. This breaks the program flow implied by the undo code: Ui --> Undo-Command --> Model --> UI Moreover, the naming of the remove() slot is illogical, because clicks can also have different effects, as for example in the cylinder-table. Therefore, move the connect() call from TableModel to the callers. In the case of TabDiveSite, move the remove() function from the model to the TabWidget, where it makes more sense. Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
Diffstat (limited to 'desktop-widgets/tableview.h')
-rw-r--r--desktop-widgets/tableview.h5
1 files changed, 1 insertions, 4 deletions
diff --git a/desktop-widgets/tableview.h b/desktop-widgets/tableview.h
index 5dc5db2b5..7b783ef02 100644
--- a/desktop-widgets/tableview.h
+++ b/desktop-widgets/tableview.h
@@ -28,10 +28,6 @@ class TableView : public QGroupBox {
public:
TableView(QWidget *parent = 0);
~TableView();
- /* The model is expected to have a 'remove' slot, that takes a QModelIndex as parameter.
- * It's also expected to have the column '1' as a trash icon. I most probably should create a
- * proxy model and add that column, will mark that as TODO. see? marked.
- */
void setModel(QAbstractItemModel *model);
void setBtnToolTip(const QString &tooltip);
void fixPlusPosition();
@@ -45,6 +41,7 @@ protected:
signals:
void addButtonClicked();
+ void itemClicked(const QModelIndex &);
private:
Ui::TableView ui;