summaryrefslogtreecommitdiffstats
path: root/desktop-widgets
diff options
context:
space:
mode:
authorGravatar Berthold Stoeger <bstoeger@mail.tuwien.ac.at>2018-01-03 18:03:28 +0100
committerGravatar Dirk Hohndel <dirk@hohndel.org>2018-01-06 10:46:07 -0800
commit59526e948aea42b977a3976293fbfdfe561dec97 (patch)
treea603c538b2bfb54731e9519a0190cd2fffa8da67 /desktop-widgets
parentb3901aa8f90499ee2a34efdddc2463105afc53f1 (diff)
downloadsubsurface-59526e948aea42b977a3976293fbfdfe561dec97.tar.gz
Remove cloud_background_sync preferences option
The preferences flag cloud_background_sync used to be used heavily in the mobile code, but is not used there anymore. Now, it is accessed only in one place, but does not do what it actually says: If it is off, the remote storage is not synced on save (but will be synced on next load). Syncing on save can also be prevented by unchecking the "Cloud online" menu checkbox. Since the latter seems more logical and general (support for non-cloud remote git repositories), remove the cloud_background_sync option. Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
Diffstat (limited to 'desktop-widgets')
-rw-r--r--desktop-widgets/preferences/preferences_network.cpp2
-rw-r--r--desktop-widgets/preferences/preferences_network.ui7
2 files changed, 0 insertions, 9 deletions
diff --git a/desktop-widgets/preferences/preferences_network.cpp b/desktop-widgets/preferences/preferences_network.cpp
index 9ea78f50b..9cc12d328 100644
--- a/desktop-widgets/preferences/preferences_network.cpp
+++ b/desktop-widgets/preferences/preferences_network.cpp
@@ -38,7 +38,6 @@ void PreferencesNetwork::refreshSettings()
ui->cloud_storage_email->setText(prefs.cloud_storage_email);
ui->cloud_storage_password->setText(prefs.cloud_storage_password);
ui->save_password_local->setChecked(prefs.save_password_local);
- ui->cloud_background_sync->setChecked(prefs.cloud_background_sync);
ui->save_uid_local->setChecked(prefs.save_userid_local);
ui->default_uid->setText(QString(prefs.userid).toUpper());
updateCloudAuthenticationState();
@@ -115,7 +114,6 @@ void PreferencesNetwork::syncSettings()
cloud->setSavePasswordLocal(ui->save_password_local->isChecked());
cloud->setPassword(password);
cloud->setVerificationStatus(prefs.cloud_verification_status);
- cloud->setBackgroundSync(ui->cloud_background_sync->isChecked());
cloud->setBaseUrl(prefs.cloud_base_url);
}
diff --git a/desktop-widgets/preferences/preferences_network.ui b/desktop-widgets/preferences/preferences_network.ui
index 0899c7c94..74f2548c1 100644
--- a/desktop-widgets/preferences/preferences_network.ui
+++ b/desktop-widgets/preferences/preferences_network.ui
@@ -216,13 +216,6 @@
</widget>
</item>
<item row="2" column="0">
- <widget class="QCheckBox" name="cloud_background_sync">
- <property name="text">
- <string>Sync to cloud in the background?</string>
- </property>
- </widget>
- </item>
- <item row="2" column="1">
<widget class="QCheckBox" name="save_password_local">
<property name="text">
<string>Save Password locally?</string>