diff options
| author |  Berthold Stoeger <bstoeger@mail.tuwien.ac.at> | 2019-11-11 21:36:51 +0100 |
|---|---|---|
| committer |  bstoeger <32835590+bstoeger@users.noreply.github.com> | 2019-11-11 22:44:58 +0100 |
| commit | e434b5aa4066990a1dbf67670e09b650d87be753 (patch) | |
| tree | 68d759ef056be49a6220130af98bd6a64e7d5388 /desktop-widgets | |
| parent | a474264cc87d10b36287bd800efc46a35a97eb78 (diff) | |
| download | subsurface-e434b5aa4066990a1dbf67670e09b650d87be753.tar.gz | |
Cleanup: introduce DiveTripModelBase::IS_TRIP_ROLE
To test whether an entry is a trip, we passed a pointer to the
trip through a QVariant and tested that for null-ity.
Passing pointers through QVariants has given us myriads of
problems in QML, therefore introduce a bool IS_TRIP_ROLE
Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
Diffstat (limited to 'desktop-widgets')
| -rw-r--r-- | desktop-widgets/divelistview.cpp | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/desktop-widgets/divelistview.cpp b/desktop-widgets/divelistview.cpp index 409b22e38..c012b9832 100644 --- a/desktop-widgets/divelistview.cpp +++ b/desktop-widgets/divelistview.cpp @@ -348,8 +348,7 @@ void DiveListView::clearTripSelection() // we want to make sure no trips are selected Q_FOREACH (const QModelIndex &index, selectionModel()->selectedRows()) { - dive_trip_t *trip = index.data(DiveTripModelBase::TRIP_ROLE).value<dive_trip *>(); - if (!trip) + if (!index.data(DiveTripModelBase::IS_TRIP_ROLE).toBool()) continue; selectionModel()->select(index, QItemSelectionModel::Deselect); } |