diff options
author | Linus Torvalds <torvalds@linux-foundation.org> | 2012-09-24 12:03:58 -0700 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2012-09-24 12:03:58 -0700 |
commit | 6ae67f96f8e2252b6d32b42708324ab77f8ff0fa (patch) | |
tree | 7a72d5ba5bd3b25d50e373622902497893d59d9f /dive.h | |
parent | 37760d830f516fe6813aabce82b6158249a691ad (diff) | |
download | subsurface-6ae67f96f8e2252b6d32b42708324ab77f8ff0fa.tar.gz |
Update cylinder info properly
The "cylinders_equal()/copy_cylinders()" functions were buggered, and
only checked (and copied) the cylinder type. That was on purpose, since
you do want to be able to change the type of a cylinder without changing
the gasmix of the cylinder.
HOWEVER, the reverse is also true: you may want to change the gasmix of
a cylinder without changing the type.
So it's not that the type of the cylinder is special - it's that the
type and the gasmix should be considered separately.
Do that properly for the equipment editing case.
Reported-by: Ďoďo <dodo.sk@gmail.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'dive.h')
-rw-r--r-- | dive.h | 2 |
1 files changed, 0 insertions, 2 deletions
@@ -97,8 +97,6 @@ extern gboolean cylinder_nodata(cylinder_t *cyl); extern gboolean cylinder_nosamples(cylinder_t *cyl); extern gboolean cylinder_none(void *_data); extern gboolean no_cylinders(cylinder_t *cyl); -extern gboolean cylinders_equal(cylinder_t *cyl1, cylinder_t *cyl2); -extern void copy_cylinders(cylinder_t *cyl1, cylinder_t *cyl2); extern gboolean no_weightsystems(weightsystem_t *ws); extern gboolean weightsystems_equal(weightsystem_t *ws1, weightsystem_t *ws2); |