Simplify string comparison

This is based on Linus' idea on the mailing list.
Treat NULL strings and empty strings as identical.

Suggested-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>

1 files changed, 6 insertions, 0 deletions

diff --git a/dive.h b/dive.h
index 5215c4997..13606f39e 100644
--- a/dive.h
+++ b/dive.h
@@ -7,6 +7,7 @@
 #include <math.h>
 #include <zip.h>
 #include <sqlite3.h>
+#include <string.h>
 
 /* Windows has no MIN/MAX macros - so let's just roll our own */
 #define MIN(x, y) ({                \
@@ -23,6 +24,11 @@
 
 #define IS_FP_SAME(_a, _b) (fabs((_a) - (_b)) < 0.000001 * MAX(fabs(_a), fabs(_b)))
 
+static inline int same_string(const char *a, const char *b)
+{
+	return !strcmp(a ? : "", b ? : "");
+}
+
 #include <libxml/tree.h>
 #include <libxslt/transform.h>