diff options
| author |  Linus Torvalds <torvalds@linux-foundation.org> | 2012-12-28 08:38:47 -0800 |
|---|---|---|
| committer |  Dirk Hohndel <dirk@hohndel.org> | 2012-12-28 09:04:59 -0800 |
| commit | 3b136f23ee4f3ddee1c157dfee2ff84fe6fa130e (patch) | |
| tree | ee026605d81a3278a55c38fcd04d45c375f20f08 /dive.h | |
| parent | fc1bb0a32cc2b665fdac804c487232ff6ab8341a (diff) | |
| download | subsurface-3b136f23ee4f3ddee1c157dfee2ff84fe6fa130e.tar.gz | |
Make add_dc_to_string() skip redundant entries
There is no point writing out divecomputer nicknames that do not exist
(or that match the dive computer model), so don't.
Also, make the function to do this static to save-xml.c, which is the
only user (I initially didn't _find_ the function to create the XML
string because it was illogically hidden in gtk-gui.c), and change the
calling convention to be more direct (pass in a string and return a
result, rather than modify a "pointer to string").
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
Diffstat (limited to 'dive.h')
| -rw-r--r-- | dive.h | 1 |
1 files changed, 0 insertions, 1 deletions
@@ -530,7 +530,6 @@ extern void flush_divelist(struct dive *dive); extern void set_dc_nickname(struct dive *dive); extern const char *get_dc_nickname(const char *model, uint32_t deviceid); extern void remember_dc(const char *model, uint32_t deviceid, const char *nickname, gboolean change_conf); -extern void add_dc_to_string(char **dc_xml, struct divecomputer *dc); #define DIVE_ERROR_PARSE 1 |