diff options
| author |  Linus Torvalds <torvalds@linux-foundation.org> | 2014-04-26 10:55:17 -0700 |
|---|---|---|
| committer |  Dirk Hohndel <dirk@hohndel.org> | 2014-04-26 17:24:12 -0700 |
| commit | 0c5ec1d6dbf386e063a11717c7bfdbec5c57fcf0 (patch) | |
| tree | 48952fba2899178633cb15ae3fa92f7b8ea1f73d /divelist.c | |
| parent | cd98e4f6dbe0a9d8731bfd5c7bf506ae73f07877 (diff) | |
| download | subsurface-0c5ec1d6dbf386e063a11717c7bfdbec5c57fcf0.tar.gz | |
Don't calculate SAC-rates for negative pressure changes
They happen - maybe the cylinder actually warmed up, or maybe the user
entered just a ending pressure without a starting pressure. Regardless,
just ignore cylinder pressure changes that go up.
Also ignore cylinders with a zero ending pressure: that's really a
*missing* pressure rather than an actual zero pressure. As Dirk says,
the scuba regulators don't even work without a healthy positive pressure
differential, so even when you breathe down a tank to "empty", it won't
be at zero pressure (this is true even with gauge pressure, where zero
means "atmospheric pressure").
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
Diffstat (limited to 'divelist.c')
| -rw-r--r-- | divelist.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/divelist.c b/divelist.c index 17f24ef7e..f0a66b456 100644 --- a/divelist.c +++ b/divelist.c @@ -311,6 +311,8 @@ static double calculate_airuse(struct dive *dive) start = cyl->start.mbar ? cyl->start : cyl->sample_start; end = cyl->end.mbar ? cyl->end : cyl->sample_end; + if (!end.mbar || start.mbar <= end.mbar) + continue; airuse += gas_volume(cyl, start) - gas_volume(cyl, end); } |