summaryrefslogtreecommitdiffstats
path: root/dives
diff options
context:
space:
mode:
authorGravatar Dirk Hohndel <dirk@hohndel.org>2015-08-30 10:10:07 -0700
committerGravatar Dirk Hohndel <dirk@hohndel.org>2015-08-30 10:14:50 -0700
commite0587cb6dfbc56feb9fd1edfc7bcdd64b7142653 (patch)
tree41c7a4a1954424b5340e67ba2a841fbffc6c8e84 /dives
parentd15a1db42846c4bee895baa9f490985c7136e0b8 (diff)
downloadsubsurface-e0587cb6dfbc56feb9fd1edfc7bcdd64b7142653.tar.gz
Fix subtle bug in dive site import from V2 file
Assume your V2 file contains two locations with different name but identical GPS location. "Blue Corner" and "Blue Corner, Palau". And you have many dives there. When reading a V2 file the GPS is read first and a dive site is looked up based on that. Let's assume the lookup by gps finds "Blue Corner, Palau". Now every time we get the "Blue Corner" site in the V2 file we look up the GPS, get "Blue Corner, Palau" as dive site, then read the name "Blue Corner" and say "oops, different site" and create a new one. Resulting in several dive sites named "Blue Corner" with identical GPS but different UUID (as we add the dive time into the SHA for the deterministic UUID). With this commit, if we have a dive site that matches the GPS but has a different name, we check if we happen to have an exact match for the dive site information from the XML file (and use it, if we have it) before creating a new dive site. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
Diffstat (limited to 'dives')
0 files changed, 0 insertions, 0 deletions