Use proper helper functions for dive location and for_each_dive

This makes the code use the "dive_has_location()" function rather than
check the longitude and latitude directly.

It also uses "for_each_dive()" rather than open-coding it.

Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>

1 files changed, 2 insertions, 3 deletions

diff --git a/gps.c b/gps.c
index f68da0383..cc6eaa3a4 100644
--- a/gps.c
+++ b/gps.c
@@ -139,9 +139,8 @@ void show_gps_locations()
 	if (!window || !map)
 		map = init_map();
 
-	for (idx = 0; idx < dive_table.nr; idx++) {
-		dp = dive_table.dives[idx];
-		if (dp->latitude.udeg != 0 || dp->longitude.udeg != 0){
+	for_each_dive(idx, dp) {
+		if (dive_has_location(dp)) {
 			add_gps_point(map, dp->latitude.udeg / 1000000.0,
 				dp->longitude.udeg / 1000000.0);
 		}