Fix incorrect memory access in nickname handling

There was one code path where we didn't strdup the nickname - and this got
triggered when parsing XML files with divecomputerid entries for dive
computers that were already in the config. The nickname is then replaced
with the nickname from the parser - and that memory is later reused...

We should cleanup that nickname, anyway, and that also takes care of
making sure we have our own copy.

Signed-off-by: Dirk Hohndel <dirk@hohndel.org>

1 files changed, 1 insertions, 1 deletions

diff --git a/gtk-gui.c b/gtk-gui.c
index c5b31348b..35bfd5116 100644
--- a/gtk-gui.c
+++ b/gtk-gui.c
@@ -2188,7 +2188,7 @@ void remember_dc(const char *model, uint32_t deviceid, const char *nickname, gbo
 		struct dcnicknamelist *nn_entry = get_dc_nicknameentry(model, deviceid);
 		if (!nn_entry->model || !*nn_entry->model)
 			nn_entry->model = model;
-		nn_entry->nickname = nickname;
+		nn_entry->nickname = cleanedup_nickname(nickname, 80);
 		replace_nickname_nicknamestring(model, deviceid, nickname);
 	}
 #if defined(NICKNAME_DEBUG)