summaryrefslogtreecommitdiffstats
path: root/main.c
diff options
context:
space:
mode:
authorGravatar Linus Torvalds <torvalds@linux-foundation.org>2011-09-19 12:39:35 -0700
committerGravatar Linus Torvalds <torvalds@linux-foundation.org>2011-09-19 12:39:35 -0700
commitfefcbf125e89735d748307d0506938e4d4105321 (patch)
tree0dde48c32134409581b30e2313fadead9e113508 /main.c
parent96005d20ea03107ea8ec065ff7fdd9dd134c521d (diff)
downloadsubsurface-fefcbf125e89735d748307d0506938e4d4105321.tar.gz
Remove dive info frame
It has always been problematic, and I've been moving things in and out of it. And it just isn't a very powerful widget. You can't *do* anything with it. The information it shows you may be useful, but the core stuff already shows up in the dive list. And the dive list is actually a much superior widget over that static dive info frame. The information that shows up in the dive list can be sorted by column, for example. So when we show temperatures or SAC numbers in the dive info frame, that's actually a very bad place to show them: we would be much better off showing it in the dive list, and then we could sort by SAC or by temperature. In other words: just remove the thing. Instead, plan to extend the dive list to contain all the information. That will probably mean that we need to change the current pane widget to be a vertical pane, rather than a horizontal one, but what's wrong with that? Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'main.c')
-rw-r--r--main.c5
1 files changed, 0 insertions, 5 deletions
diff --git a/main.c b/main.c
index e6f58ce5b..ac043fd39 100644
--- a/main.c
+++ b/main.c
@@ -422,7 +422,6 @@ int main(int argc, char **argv)
GtkWidget *paned;
GtkWidget *info_box;
GtkWidget *notebook;
- GtkWidget *frame;
GtkWidget *dive_info;
GtkWidget *equipment;
GtkWidget *menubar;
@@ -469,10 +468,6 @@ int main(int argc, char **argv)
info_box = gtk_vbox_new(FALSE, 6);
gtk_paned_add2(GTK_PANED(paned), info_box);
- /* Frame for minimal dive info */
- frame = dive_info_frame();
- gtk_box_pack_start(GTK_BOX(info_box), frame, FALSE, TRUE, 6);
-
/* Notebook for dive info vs profile vs .. */
notebook = gtk_notebook_new();
g_signal_connect(notebook, "switch-page", G_CALLBACK(switch_page), NULL);