summaryrefslogtreecommitdiffstats
path: root/mobile-widgets/qml/DiveDetailsEdit.qml
diff options
context:
space:
mode:
authorGravatar Jan Mulder <jlmulder@xs4all.nl>2017-07-18 19:17:15 +0200
committerGravatar Dirk Hohndel <dirk@hohndel.org>2017-07-19 11:12:35 +0900
commit883063875e253a1cf944c5f524d46ec9ab0b796d (patch)
tree8302704c487cf5e06e28769ff697188a6751b879 /mobile-widgets/qml/DiveDetailsEdit.qml
parent5c7ac7e7d1f9dcec01ea3af19963dd97ead3572f (diff)
downloadsubsurface-883063875e253a1cf944c5f524d46ec9ab0b796d.tar.gz
BLE serial read/write buffer
The adapted define was confusingly wrong. Apparently, the BUFSIZ define was coming from some include file, and was dependent on platform (Linux 8K, Andorid 1K). Simple rewrite to a new define and a proper value for both Linux and Android. If 4K is big enhough, is a little uncertain, as its depends on the read behavior of all libdivecomputer parsers using this serial BLE interface. The buffer size needed (on read, as that is the most prominent direction when interfacing with DCs) is (most likely) 2x the maximum block the libdc parsers request at once. I did not study all parsers, but the Shearwater parser request 20 bytes at once (we know that from the 1 packet at the time read, we had before). The OSTC parser request 1K blocks for data that is longer than 1K (like profiles, header tables). The 1K we had on Android was working for Shearwater, Eon Steel, but not for OSTC,as its reads 1K at the time at max, and overflowing the buffer. So 32k or 64k seems way to big (as in, much bigger than any libdc read). Signed-off-by: Jan Mulder <jlmulder@xs4all.nl>
Diffstat (limited to 'mobile-widgets/qml/DiveDetailsEdit.qml')
0 files changed, 0 insertions, 0 deletions