diff options
author | Dirk Hohndel <dirk@hohndel.org> | 2020-01-29 11:26:22 +0200 |
---|---|---|
committer | Dirk Hohndel <dirk@hohndel.org> | 2020-01-30 07:45:25 +0200 |
commit | 08e39f9d2d293ac22e6174e7b723abb805650552 (patch) | |
tree | c669bf41f8e3df46e273367283abe1cf966bbabb /mobile-widgets/qml/DiveSummary.qml | |
parent | a534f1a25c36e4dbd27cc7d341d0c0d1a92d7cc7 (diff) | |
download | subsurface-08e39f9d2d293ac22e6174e7b723abb805650552.tar.gz |
mobile/dive summary: rewrite statistics code
There were quite a few issues with the code - clearly a complete failure of
code review.
- all values were '??' if a period contained no dives
- imperial units were not calculated at all
- significant truncation and data loss in the way totals were added as meters
and minutes instead of the higher precision data that is available
- several issues in striing conversion methodology, e.g. missing zero padding
for minutes
- missing maxSac
- incorrectly calculated avgSac
- incorrectly claculated number of EANx dives
- hard to read code with most variables named 'temp'
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
Diffstat (limited to 'mobile-widgets/qml/DiveSummary.qml')
-rw-r--r-- | mobile-widgets/qml/DiveSummary.qml | 16 |
1 files changed, 13 insertions, 3 deletions
diff --git a/mobile-widgets/qml/DiveSummary.qml b/mobile-widgets/qml/DiveSummary.qml index b690109e4..d55443815 100644 --- a/mobile-widgets/qml/DiveSummary.qml +++ b/mobile-widgets/qml/DiveSummary.qml @@ -181,7 +181,7 @@ Kirigami.ScrollablePage { text: Backend.diveSummaryText[19] } TemplateLabel { - text: qsTr("avg. SAC") + text: qsTr("max. SAC") font.bold: true } TemplateLabel { @@ -190,6 +190,16 @@ Kirigami.ScrollablePage { TemplateLabel { text: Backend.diveSummaryText[21] } + TemplateLabel { + text: qsTr("avg. SAC") + font.bold: true + } + TemplateLabel { + text: Backend.diveSummaryText[22] + } + TemplateLabel { + text: Backend.diveSummaryText[23] + } TemplateLabel { Layout.columnSpan: 3 @@ -200,10 +210,10 @@ Kirigami.ScrollablePage { font.bold: true } TemplateLabel { - text: Backend.diveSummaryText[22] + text: Backend.diveSummaryText[24] } TemplateLabel { - text: Backend.diveSummaryText[23] + text: Backend.diveSummaryText[25] } } |