diff options
| author |  Berthold Stoeger <bstoeger@mail.tuwien.ac.at> | 2018-05-26 15:22:22 +0200 |
|---|---|---|
| committer |  Dirk Hohndel <dirk@hohndel.org> | 2018-05-26 09:19:42 -0700 |
| commit | 0de862971e98a6db88562b1e3424ee9cd3024679 (patch) | |
| tree | 47a3fcb2814a698814df790551b16c2316a1b687 /mobile-widgets/qmlmanager.h | |
| parent | b18b10b46710728d898c3bfb786fd963e579e374 (diff) | |
| download | subsurface-0de862971e98a6db88562b1e3424ee9cd3024679.tar.gz | |
Cleanup: remove reply and request member variables in QMLManager
The reply member variable was used to access the reply in the
handleSslErrors, handleError and retrieveUserid slots. This is a
very scary proposition in the light of multi-threading. Instead,
the reply can be accessed by using the QObject::sender() function.
Thus, we can remove the member variable.
The request member was just downright weird. This was only used
locally to describe a network request. Since QNetworkAccessManager::get()
copies the request, it can be destructed right away. Nevertheless,
the data was kept as a subobject. Remove member and make it function-local.
Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
Diffstat (limited to 'mobile-widgets/qmlmanager.h')
| -rw-r--r-- | mobile-widgets/qmlmanager.h | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/mobile-widgets/qmlmanager.h b/mobile-widgets/qmlmanager.h index f632610f6..2f1236d76 100644 --- a/mobile-widgets/qmlmanager.h +++ b/mobile-widgets/qmlmanager.h @@ -216,8 +216,6 @@ private: GpsLocation *locationProvider; bool m_loadFromCloud; static QMLManager *m_instance; - QNetworkReply *reply; - QNetworkRequest request; struct dive *deletedDive; struct dive_trip *deletedTrip; QString m_notificationText; |