diff options
| author |  jan Iversen <jan@casacondor.com> | 2020-01-02 08:30:40 +0100 |
|---|---|---|
| committer |  Dirk Hohndel <dirk@hohndel.org> | 2020-01-04 10:56:55 -0800 |
| commit | d000cb2b0d038264abb1384c037da10d753549b9 (patch) | |
| tree | 2e022d4e327c898a488178c6f0a51831e6fce0b7 /mobile-widgets | |
| parent | 342a8db93a59897bd71ae52266595754021e980a (diff) | |
| download | subsurface-d000cb2b0d038264abb1384c037da10d753549b9.tar.gz | |
mobile-widgetes/qml: standardize QML/C++ interface
Do not use a.set_b(value); it works, but it introduces yet another way of using
the QML/C++ interface, furthermore the function might not be called set_b in
some future, which is the reason the function is define in Q_PROPERTY
Use a.b = value, that respects Q_PROPERTY, and is slightly more performant,
most importantly it's like all the other settings so noone starts wondering why
this is special.
Signed-off-by: Jan Iversen <jan@casacondor.com>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
Diffstat (limited to 'mobile-widgets')
| -rw-r--r-- | mobile-widgets/qml/Settings.qml | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/mobile-widgets/qml/Settings.qml b/mobile-widgets/qml/Settings.qml index 100ecb9e5..60aeefd2f 100644 --- a/mobile-widgets/qml/Settings.qml +++ b/mobile-widgets/qml/Settings.qml @@ -461,7 +461,7 @@ Kirigami.ScrollablePage { enabled: PrefUnits.unit_system === "metric" Layout.preferredWidth: gridWidth * 0.25 onClicked: { - PrefUnits.set_unit_system("imperial") + PrefUnits.unit_system = "imperial" manager.changesNeedSaving() manager.refreshDiveList() } @@ -478,7 +478,7 @@ Kirigami.ScrollablePage { enabled: PrefUnits.unit_system === "imperial" Layout.preferredWidth: gridWidth * 0.25 onClicked: { - PrefUnits.set_unit_system("metric") + PrefUnits.unit_system = "metric" manager.changesNeedSaving() manager.refreshDiveList() } @@ -516,7 +516,7 @@ Kirigami.ScrollablePage { checked: PrefGeneral.filterFullTextNotes Layout.preferredWidth: gridWidth * 0.25 onClicked: { - PrefGeneral.set_filterFullTextNotes(checked) + PrefGeneral.filterFullTextNotes = checked } } @@ -532,7 +532,7 @@ Kirigami.ScrollablePage { checked: PrefGeneral.filterCaseSensitive Layout.preferredWidth: gridWidth * 0.25 onClicked: { - PrefGeneral.set_filterCaseSensitive(checked) + PrefGeneral.filterCaseSensitive = checked } } |