summaryrefslogtreecommitdiffstats
path: root/packaging
diff options
context:
space:
mode:
authorGravatar Berthold Stoeger <bstoeger@mail.tuwien.ac.at>2018-09-17 17:34:13 +0200
committerGravatar Dirk Hohndel <dirk@hohndel.org>2018-09-19 14:44:34 -0700
commit21b1550739b9a3fe4ab27cabd4a8587249048f71 (patch)
tree6a7d00658b720a334df0aa16c6999c6704116734 /packaging
parent92deb7aa70e79db43b143c965c6386a6b06b4a2b (diff)
downloadsubsurface-21b1550739b9a3fe4ab27cabd4a8587249048f71.tar.gz
Dive media: on import read metadata only once
On import of dive media, the timestamp is read from the metadata to check if the image belongs to the selected dives. The pictures are then listed in a dialog. Currently, the metadata is read twice if images are outside of a dive: once in picture_check_valid() and if it turns out that the picture is not valid again in picture_get_time() to display the proper timestamp. Even though metadata-extraction is reasonably fast, this is a bit of an embarrassment. Instead, read the timestamps only once in the constructor of the dialog and from then on only used these timestamps. Keep the timestamps in a QVector. Rename the picture_check_valid() function to picture_check_valid_time() and pass a timestamp instead of a filename. Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
Diffstat (limited to 'packaging')
0 files changed, 0 insertions, 0 deletions