Avoid duplicate dive_trip entries

When inserting a trip into the dive_trip_list we already check for
duplicate trips, but we still kept the additional dive_trip around.

With this change we instead replace it with the existing one.

Signed-off-by: Dirk Hohndel <dirk@hohndel.org>

1 files changed, 1 insertions, 6 deletions

diff --git a/parse-xml.c b/parse-xml.c
index 1569c8c5c..a1eb21070 100644
--- a/parse-xml.c
+++ b/parse-xml.c
@@ -39,11 +39,6 @@ void record_dive(struct dive *dive)
 	dive_table.nr = nr+1;
 }
 
-void record_trip(struct dive *trip)
-{
-	insert_trip(trip);
-}
-
 static void delete_dive_renumber(struct dive **dives, int i, int nr)
 {
 	struct dive *dive = dives[i];
@@ -1213,7 +1208,7 @@ static void trip_end(void)
 {
 	if (!cur_trip)
 		return;
-	record_trip(cur_trip);
+	insert_trip(&cur_trip);
 	cur_trip = NULL;
 }