diff options
author | Lubomir I. Ivanov <neolit123@gmail.com> | 2015-11-06 14:40:20 +0200 |
---|---|---|
committer | Dirk Hohndel <dirk@hohndel.org> | 2015-11-06 09:58:34 -0800 |
commit | 8e7be1b50a93e667663b29d84dbd66c2a31975dc (patch) | |
tree | 8c18b762d72009a5819563951dc2c7d64d20cd2b /profile-widget/diveprofileitem.h | |
parent | 61e768036e63d4006fc5b46b687ecf9fd1150f21 (diff) | |
download | subsurface-8e7be1b50a93e667663b29d84dbd66c2a31975dc.tar.gz |
Untangle DiveCalculatedCeiling from MainWindow
DiveCalculatedCeiling is the last class the references
MainWindow in the profile-widget stack.
In modelDataChanged() it looks for the information()
widget and sets a slot for the dateTimeChanged() signal that
information() emits.
To solve the issue we make DiveCalculatedCeiling recieve
a ProfileWidget2 reference and make ProfileWidget2 emit
the dateTimeChangedItems() signal.
ProfileWidget2 itself listens for the dateTimeChanged()
signal that information() emits and emits dateTimeChangedItems()
to notify any possible children/item listeners in the
ProfileWidget2::dateTimeChanged() slot.
The connection between ProfileWidget2 and information()
is set in MainWindow. This makes DiveCalculatedCeiling
unaware of MainWindow and which class originally emits
the dateTimeChanged() signal to ProfileWidget2.
Signed-off-by: Lubomir I. Ivanov <neolit123@gmail.com>
--
Think delegation.
Tomaz, please take a look at this one, to double check
if i messed up.
also i have zero idea how the mobile app is setting these
connections, if it does so even.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
Diffstat (limited to 'profile-widget/diveprofileitem.h')
-rw-r--r-- | profile-widget/diveprofileitem.h | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/profile-widget/diveprofileitem.h b/profile-widget/diveprofileitem.h index 0bba7f7a3..8f9a56f6e 100644 --- a/profile-widget/diveprofileitem.h +++ b/profile-widget/diveprofileitem.h @@ -21,6 +21,7 @@ This is a generically item and should be used as a base for others, I think... */ +class ProfileWidget2; class DivePlotDataModel; class DiveTextItem; class DiveCartesianAxis; @@ -175,7 +176,7 @@ class DiveCalculatedCeiling : public AbstractProfilePolygonItem { Q_OBJECT public: - DiveCalculatedCeiling(); + DiveCalculatedCeiling(ProfileWidget2 *profileWidget); virtual void modelDataChanged(const QModelIndex &topLeft = QModelIndex(), const QModelIndex &bottomRight = QModelIndex()); virtual void paint(QPainter *painter, const QStyleOptionGraphicsItem *option, QWidget *widget = 0); virtual void settingsChanged(); @@ -184,6 +185,9 @@ public slots: void recalc(); +protected: + ProfileWidget2 *profileWidget; + private: bool is3mIncrement; }; @@ -200,7 +204,7 @@ public: class DiveCalculatedTissue : public DiveCalculatedCeiling { Q_OBJECT public: - DiveCalculatedTissue(); + DiveCalculatedTissue(ProfileWidget2 *profileWidget); virtual void settingsChanged(); }; |