Cleanup: consistently use qPrintable()

Replace constructs of the kind
  s.toUtf8().data(),
  s.toUtf8().constData(),
  s.toLocal8Bit().data(),
  s.toLocal8Bit.constData() or
  qUtf8Printable(s)
by
  qPrintable(s).

This is concise, consistent and - in principle - more performant than
the .data() versions.

Sadly, owing to a suboptimal implementation, qPrintable(s) currently
is a pessimization compared to s.toUtf8().data(). A fix is scheduled for
new Qt versions: https://codereview.qt-project.org/#/c/221331/

Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>

1 files changed, 3 insertions, 3 deletions

diff --git a/profile-widget/profilewidget2.cpp b/profile-widget/profilewidget2.cpp
index b1ba31620..b65e76743 100644
--- a/profile-widget/profilewidget2.cpp
+++ b/profile-widget/profilewidget2.cpp
@@ -1582,7 +1582,7 @@ void ProfileWidget2::changeGas()
 			gasChangeEvent = gasChangeEvent->next;
 		}
 	}
-	validate_gas(gas.toUtf8().constData(), &gasmix);
+	validate_gas(qPrintable(gas), &gasmix);
 	QRegExp rx("\\(\\D*(\\d+)");
 	int tank;
 	if (rx.indexIn(action->text()) > -1) {
@@ -1667,8 +1667,8 @@ void ProfileWidget2::editName()
 		// order is important! first update the current dive (by matching the unchanged event),
 		// then update the displayed dive (as event is part of the events on displayed dive
 		// and will be freed as part of changing the name!
-		update_event_name(current_dive, event, newName.toUtf8().data());
-		update_event_name(&displayed_dive, event, newName.toUtf8().data());
+		update_event_name(current_dive, event, qPrintable(newName));
+		update_event_name(&displayed_dive, event, qPrintable(newName));
 		invalidate_dive_cache(current_dive);
 		mark_divelist_changed(true);
 		replot();