summaryrefslogtreecommitdiffstats
path: root/profile-widget
diff options
context:
space:
mode:
authorGravatar Tomaz Canabrava <tomaz.canabrava@intel.com>2016-01-25 15:54:23 -0200
committerGravatar Dirk Hohndel <dirk@hohndel.org>2016-01-25 13:04:01 -0800
commit2c5fad73e8939409639548571dcb942e6b2cb792 (patch)
treeacd1f2cd4adaeb6f1c642cf6c1d57baecafbea09 /profile-widget
parent5afda93b71880395a78c121b76c234e1953edf1b (diff)
downloadsubsurface-2c5fad73e8939409639548571dcb942e6b2cb792.tar.gz
Start to use the QSettings ObjectWrapper
start of the QSettinsg Object Wrapper usage on the code this first patch removes two macros that generated around 200 lines in runtime for something like a quarter of it Basically, whenever we changed anything we called the PreferencesDialog::settingsChanged and connected everythign to that signal, now each setting has it's own changed signal and we can call it directly. The best thing about this approach is that we don't trigger repaints for things that are not directly profile related. ( actually we still do, but the plan is to remove them in due time) this commit breaks correct atualization of the profile (because everything was connected to PreferencesDialog::settingsChanged) and now I need to hunt a bit for the correct connections Signed-off-by: Tomaz Canabrava <tomaz.canabrava@intel.com> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
Diffstat (limited to 'profile-widget')
-rw-r--r--profile-widget/profilewidget2.cpp7
-rw-r--r--profile-widget/profilewidget2.h1
2 files changed, 8 insertions, 0 deletions
diff --git a/profile-widget/profilewidget2.cpp b/profile-widget/profilewidget2.cpp
index f89590033..629149030 100644
--- a/profile-widget/profilewidget2.cpp
+++ b/profile-widget/profilewidget2.cpp
@@ -15,6 +15,7 @@
#include "models.h"
#include "divepicturemodel.h"
#include "divelist.h"
+#include <subsurface-qt/SettingsObjectWrapper.h>
#ifndef SUBSURFACE_MOBILE
#include "diveplanner.h"
#include "simplewidgets.h"
@@ -732,6 +733,12 @@ void ProfileWidget2::dateTimeChanged()
emit dateTimeChangedItems();
}
+void ProfileWidget2::actionRequestedReplot(bool triggered)
+{
+ Q_UNUSED(triggered);
+ settingsChanged();
+}
+
void ProfileWidget2::settingsChanged()
{
// if we are showing calculated ceilings then we have to replot()
diff --git a/profile-widget/profilewidget2.h b/profile-widget/profilewidget2.h
index 9255fe3aa..ad593a8d7 100644
--- a/profile-widget/profilewidget2.h
+++ b/profile-widget/profilewidget2.h
@@ -103,6 +103,7 @@ public
slots: // Necessary to call from QAction's signals.
void dateTimeChanged();
void settingsChanged();
+ void actionRequestedReplot(bool triggered);
void setEmptyState();
void setProfileState();
void setPlanState();