diff options
| author |  Rolf Eike Beer <eike@sf-mail.de> | 2019-04-01 22:15:19 +0200 |
|---|---|---|
| committer |  Dirk Hohndel <dirk@hohndel.org> | 2019-04-12 12:59:17 +0300 |
| commit | c4c8094e32ad78dee558a80584470172f48c45b1 (patch) | |
| tree | 4fede2acf0f1a3cee2182d96b1b3efa33e4fd8ff /profile-widget | |
| parent | 2b9ca488fd18dc9d65d42dc5900e120a07e5b3f6 (diff) | |
| download | subsurface-c4c8094e32ad78dee558a80584470172f48c45b1.tar.gz | |
get rid of some foreach and Q_FOREACH constructs
See https://www.kdab.com/goodbye-q_foreach/
This is reduced to the places where the container is const or can be made const
without the need to always introduce an extra variable. Sadly qAsConst (Qt 5.7)
and std::as_const (C++17) are not available in all supported setups.
Also do some minor cleanups along the way.
Signed-off-by: Rolf Eike Beer <eike@sf-mail.de>
Diffstat (limited to 'profile-widget')
| -rw-r--r-- | profile-widget/divetooltipitem.cpp | 5 | ||||
| -rw-r--r-- | profile-widget/profilewidget2.cpp | 4 |
2 files changed, 5 insertions, 4 deletions
diff --git a/profile-widget/divetooltipitem.cpp b/profile-widget/divetooltipitem.cpp index 0d3e6728c..f88d3b769 100644 --- a/profile-widget/divetooltipitem.cpp +++ b/profile-widget/divetooltipitem.cpp @@ -272,8 +272,9 @@ void ToolTipItem::refresh(const QPointF &pos) } entryToolTip.first->setPixmap(tissues); - Q_FOREACH (QGraphicsItem *item, scene()->items(pos, Qt::IntersectsItemBoundingRect - ,Qt::DescendingOrder, scene()->views().first()->transform())) { + const auto l = scene()->items(pos, Qt::IntersectsItemBoundingRect, Qt::DescendingOrder, + scene()->views().first()->transform()); + for (QGraphicsItem *item: l) { if (!item->toolTip().isEmpty()) addToolTip(item->toolTip()); } diff --git a/profile-widget/profilewidget2.cpp b/profile-widget/profilewidget2.cpp index 157ab9fcd..236afb850 100644 --- a/profile-widget/profilewidget2.cpp +++ b/profile-widget/profilewidget2.cpp @@ -1101,9 +1101,9 @@ bool ProfileWidget2::eventFilter(QObject *object, QEvent *event) #endif template <typename T> -static void hideAll(T &container) +static void hideAll(const T &container) { - Q_FOREACH (auto *item, container) + for (auto *item: container) item->setVisible(false); } |