diff options
author | Berthold Stoeger <bstoeger@mail.tuwien.ac.at> | 2018-09-29 22:13:44 +0200 |
---|---|---|
committer | Dirk Hohndel <dirk@hohndel.org> | 2018-09-29 15:23:25 -0700 |
commit | 574065b31430245a66808561b1b95139c4cd19f2 (patch) | |
tree | 844736a0bf6969af96953db49d247123ff92f787 /profile-widget | |
parent | d7e3d68f368a2febcc17b436e097a97a7c0f8ad3 (diff) | |
download | subsurface-574065b31430245a66808561b1b95139c4cd19f2.tar.gz |
Cleanup: reinstate override modifiers
This reverts commit 1c4a859c8d0b37b2e938209fe9c4d99e9758327a,
where the override modifiers were removed owing to the noisy
"inconsistent override modifiers" which is default-on in clang.
This warning was disabled in 77577f717f5aad38ea8c4c41c10c181486c4337f,
so we can reinstate the overrides.
Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
Diffstat (limited to 'profile-widget')
-rw-r--r-- | profile-widget/divepixmapitem.h | 2 | ||||
-rw-r--r-- | profile-widget/diveprofileitem.h | 50 | ||||
-rw-r--r-- | profile-widget/profilewidget2.h | 22 | ||||
-rw-r--r-- | profile-widget/ruleritem.h | 2 |
4 files changed, 38 insertions, 38 deletions
diff --git a/profile-widget/divepixmapitem.h b/profile-widget/divepixmapitem.h index fc4eb1682..cf5b86d7c 100644 --- a/profile-widget/divepixmapitem.h +++ b/profile-widget/divepixmapitem.h @@ -20,7 +20,7 @@ class CloseButtonItem : public DivePixmapItem { public: CloseButtonItem(QGraphicsItem *parent = 0); protected: - void mousePressEvent(QGraphicsSceneMouseEvent *event); + void mousePressEvent(QGraphicsSceneMouseEvent *event) override; public slots: void hide(); void show(); diff --git a/profile-widget/diveprofileitem.h b/profile-widget/diveprofileitem.h index f09c101d1..36f6e5980 100644 --- a/profile-widget/diveprofileitem.h +++ b/profile-widget/diveprofileitem.h @@ -72,10 +72,10 @@ class DiveProfileItem : public AbstractProfilePolygonItem { public: DiveProfileItem(); - void paint(QPainter *painter, const QStyleOptionGraphicsItem *option, QWidget *widget = 0); - void modelDataChanged(const QModelIndex &topLeft = QModelIndex(), const QModelIndex &bottomRight = QModelIndex()); + void paint(QPainter *painter, const QStyleOptionGraphicsItem *option, QWidget *widget = 0) override; + void modelDataChanged(const QModelIndex &topLeft = QModelIndex(), const QModelIndex &bottomRight = QModelIndex()) override; void settingsToggled(bool toggled); - void settingsChanged(); + void settingsChanged() override; void plot_depth_sample(struct plot_data *entry, QFlags<Qt::AlignmentFlag> flags, const QColor &color); int maxCeiling(int row); @@ -89,8 +89,8 @@ class DiveMeanDepthItem : public AbstractProfilePolygonItem { Q_OBJECT public: DiveMeanDepthItem(); - void modelDataChanged(const QModelIndex &topLeft = QModelIndex(), const QModelIndex &bottomRight = QModelIndex()); - void paint(QPainter *painter, const QStyleOptionGraphicsItem *option, QWidget *widget = 0); + void modelDataChanged(const QModelIndex &topLeft = QModelIndex(), const QModelIndex &bottomRight = QModelIndex()) override; + void paint(QPainter *painter, const QStyleOptionGraphicsItem *option, QWidget *widget = 0) override; private: void createTextItem(); @@ -102,8 +102,8 @@ class DiveTemperatureItem : public AbstractProfilePolygonItem { Q_OBJECT public: DiveTemperatureItem(); - void modelDataChanged(const QModelIndex &topLeft = QModelIndex(), const QModelIndex &bottomRight = QModelIndex()); - void paint(QPainter *painter, const QStyleOptionGraphicsItem *option, QWidget *widget = 0); + void modelDataChanged(const QModelIndex &topLeft = QModelIndex(), const QModelIndex &bottomRight = QModelIndex()) override; + void paint(QPainter *painter, const QStyleOptionGraphicsItem *option, QWidget *widget = 0) override; private: void createTextItem(int seconds, int mkelvin); @@ -113,8 +113,8 @@ class DiveHeartrateItem : public AbstractProfilePolygonItem { Q_OBJECT public: DiveHeartrateItem(); - void modelDataChanged(const QModelIndex &topLeft, const QModelIndex &bottomRight); - void paint(QPainter *painter, const QStyleOptionGraphicsItem *option, QWidget *widget); + void modelDataChanged(const QModelIndex &topLeft, const QModelIndex &bottomRight) override; + void paint(QPainter *painter, const QStyleOptionGraphicsItem *option, QWidget *widget) override; private: void createTextItem(int seconds, int hr); @@ -125,8 +125,8 @@ class DivePercentageItem : public AbstractProfilePolygonItem { Q_OBJECT public: DivePercentageItem(int i); - void modelDataChanged(const QModelIndex &topLeft, const QModelIndex &bottomRight); - void paint(QPainter *painter, const QStyleOptionGraphicsItem *option, QWidget *widget); + void modelDataChanged(const QModelIndex &topLeft, const QModelIndex &bottomRight) override; + void paint(QPainter *painter, const QStyleOptionGraphicsItem *option, QWidget *widget) override; private: QString visibilityKey; @@ -139,8 +139,8 @@ class DiveAmbPressureItem : public AbstractProfilePolygonItem { Q_OBJECT public: DiveAmbPressureItem(); - void modelDataChanged(const QModelIndex &topLeft, const QModelIndex &bottomRight); - void paint(QPainter *painter, const QStyleOptionGraphicsItem *option, QWidget *widget); + void modelDataChanged(const QModelIndex &topLeft, const QModelIndex &bottomRight) override; + void paint(QPainter *painter, const QStyleOptionGraphicsItem *option, QWidget *widget) override; private: QString visibilityKey; @@ -150,8 +150,8 @@ class DiveGFLineItem : public AbstractProfilePolygonItem { Q_OBJECT public: DiveGFLineItem(); - void modelDataChanged(const QModelIndex &topLeft, const QModelIndex &bottomRight); - void paint(QPainter *painter, const QStyleOptionGraphicsItem *option, QWidget *widget); + void modelDataChanged(const QModelIndex &topLeft, const QModelIndex &bottomRight) override; + void paint(QPainter *painter, const QStyleOptionGraphicsItem *option, QWidget *widget) override; private: QString visibilityKey; @@ -161,8 +161,8 @@ class DiveGasPressureItem : public AbstractProfilePolygonItem { Q_OBJECT public: - void modelDataChanged(const QModelIndex &topLeft = QModelIndex(), const QModelIndex &bottomRight = QModelIndex()); - void paint(QPainter *painter, const QStyleOptionGraphicsItem *option, QWidget *widget = 0); + void modelDataChanged(const QModelIndex &topLeft = QModelIndex(), const QModelIndex &bottomRight = QModelIndex()) override; + void paint(QPainter *painter, const QStyleOptionGraphicsItem *option, QWidget *widget = 0) override; private: void plotPressureValue(int mbar, int sec, QFlags<Qt::AlignmentFlag> align, double offset); @@ -175,9 +175,9 @@ class DiveCalculatedCeiling : public AbstractProfilePolygonItem { public: DiveCalculatedCeiling(ProfileWidget2 *profileWidget); - void modelDataChanged(const QModelIndex &topLeft = QModelIndex(), const QModelIndex &bottomRight = QModelIndex()); - void paint(QPainter *painter, const QStyleOptionGraphicsItem *option, QWidget *widget = 0); - void settingsChanged(); + void modelDataChanged(const QModelIndex &topLeft = QModelIndex(), const QModelIndex &bottomRight = QModelIndex()) override; + void paint(QPainter *painter, const QStyleOptionGraphicsItem *option, QWidget *widget = 0) override; + void settingsChanged() override; public slots: @@ -195,8 +195,8 @@ class DiveReportedCeiling : public AbstractProfilePolygonItem { public: DiveReportedCeiling(); - void modelDataChanged(const QModelIndex &topLeft = QModelIndex(), const QModelIndex &bottomRight = QModelIndex()); - void paint(QPainter *painter, const QStyleOptionGraphicsItem *option, QWidget *widget = 0); + void modelDataChanged(const QModelIndex &topLeft = QModelIndex(), const QModelIndex &bottomRight = QModelIndex()) override; + void paint(QPainter *painter, const QStyleOptionGraphicsItem *option, QWidget *widget = 0) override; }; class DiveCalculatedTissue : public DiveCalculatedCeiling { @@ -204,15 +204,15 @@ class DiveCalculatedTissue : public DiveCalculatedCeiling { public: DiveCalculatedTissue(ProfileWidget2 *profileWidget); void setVisible(bool visible); - void settingsChanged(); + void settingsChanged() override; }; class PartialPressureGasItem : public AbstractProfilePolygonItem { Q_OBJECT public: PartialPressureGasItem(); - void paint(QPainter *painter, const QStyleOptionGraphicsItem *option, QWidget *widget = 0); - void modelDataChanged(const QModelIndex &topLeft = QModelIndex(), const QModelIndex &bottomRight = QModelIndex()); + void paint(QPainter *painter, const QStyleOptionGraphicsItem *option, QWidget *widget = 0) override; + void modelDataChanged(const QModelIndex &topLeft = QModelIndex(), const QModelIndex &bottomRight = QModelIndex()) override; void setThresholdSettingsKey(const double *prefPointerMin, const double *prefPointerMax); void setVisibilitySettingsKey(const QString &setVisibilitySettingsKey); void setColors(const QColor &normalColor, const QColor &alertColor); diff --git a/profile-widget/profilewidget2.h b/profile-widget/profilewidget2.h index b7cdc8e66..288407381 100644 --- a/profile-widget/profilewidget2.h +++ b/profile-widget/profilewidget2.h @@ -84,7 +84,7 @@ public: double getFontPrintScale(); void setFontPrintScale(double scale); #ifndef SUBSURFACE_MOBILE - bool eventFilter(QObject *, QEvent *); + bool eventFilter(QObject *, QEvent *) override; void clearHandlers(); #endif void recalcCeiling(); @@ -146,18 +146,18 @@ slots: // Necessary to call from QAction's signals. #endif protected: - void resizeEvent(QResizeEvent *event); + void resizeEvent(QResizeEvent *event) override; #ifndef SUBSURFACE_MOBILE - void wheelEvent(QWheelEvent *event); - void mouseMoveEvent(QMouseEvent *event); - void contextMenuEvent(QContextMenuEvent *event); - void mouseDoubleClickEvent(QMouseEvent *event); - void mousePressEvent(QMouseEvent *event); - void mouseReleaseEvent(QMouseEvent *event); + void wheelEvent(QWheelEvent *event) override; + void mouseMoveEvent(QMouseEvent *event) override; + void contextMenuEvent(QContextMenuEvent *event) override; + void mouseDoubleClickEvent(QMouseEvent *event) override; + void mousePressEvent(QMouseEvent *event) override; + void mouseReleaseEvent(QMouseEvent *event) override; #endif - void dropEvent(QDropEvent *event); - void dragEnterEvent(QDragEnterEvent *event); - void dragMoveEvent(QDragMoveEvent *event); + void dropEvent(QDropEvent *event) override; + void dragEnterEvent(QDragEnterEvent *event) override; + void dragMoveEvent(QDragMoveEvent *event) override; private: /*methods*/ diff --git a/profile-widget/ruleritem.h b/profile-widget/ruleritem.h index 1fdb959a2..3a6c59480 100644 --- a/profile-widget/ruleritem.h +++ b/profile-widget/ruleritem.h @@ -22,7 +22,7 @@ public: void recalculate(); protected: - void mouseMoveEvent(QGraphicsSceneMouseEvent *event); + void mouseMoveEvent(QGraphicsSceneMouseEvent *event) override; private: struct plot_info pInfo; struct plot_data *entry; |