summaryrefslogtreecommitdiffstats
path: root/profile.c
diff options
context:
space:
mode:
authorGravatar Linus Torvalds <torvalds@linux-foundation.org>2013-01-23 12:33:26 -0800
committerGravatar Dirk Hohndel <dirk@hohndel.org>2013-01-23 12:55:39 -0800
commit413b9026dd01e81cf804db27f8b0c06c48e833e2 (patch)
treefd1a82aa57a0f2b376399a682071a30a54c99415 /profile.c
parentaac44f9b0740726dd9d8cc9cce80b2e99626d0e1 (diff)
downloadsubsurface-413b9026dd01e81cf804db27f8b0c06c48e833e2.tar.gz
Fix temperature rounding issues
Temperatures can actually be negative, which means that rounding by adding 0.5 and casting to 'int' is not correct. We could use '(int)(rint(val))' instead, but the only place we care about might as well just print out the floating point representation with a precision of two digits instead. So if you have a dive computer that gives you the precision, you might see '3.5˚C' as the temperature. Remove the helper functions that nobody uses and that get the rounding wrong anyway. Reported-by: Henrik Brautaset Aronsen <subsurface@henrik.synth.no> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
Diffstat (limited to 'profile.c')
-rw-r--r--profile.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/profile.c b/profile.c
index 18987c274..4aa70ad11 100644
--- a/profile.c
+++ b/profile.c
@@ -894,7 +894,7 @@ static void plot_single_temp_text(struct graphics_context *gc, int sec, int mkel
deg = get_temp_units(mkelvin, &unit);
- plot_text(gc, &tro, sec, mkelvin, "%d%s", (int)(deg + 0.5), unit);
+ plot_text(gc, &tro, sec, mkelvin, "%.2g%s", deg, unit);
}
static void plot_temperature_text(struct graphics_context *gc, struct plot_info *pi)