diff options
author | Dirk Hohndel <dirk@hohndel.org> | 2014-03-06 16:16:10 -0800 |
---|---|---|
committer | Dirk Hohndel <dirk@hohndel.org> | 2014-03-06 16:16:10 -0800 |
commit | 211ff0e63b604e06a7ae98bf0693715bbf426e64 (patch) | |
tree | f29ccc3dcb85f939507c452857f4bdf4159eb614 /profile.c | |
parent | 8ab1fa398364577f1f3fe4a30f1a60c13801d347 (diff) | |
download | subsurface-211ff0e63b604e06a7ae98bf0693715bbf426e64.tar.gz |
Fix theoretical uninitialized read
We should never read cur_pr[cyl] if cyl isn't used during a dive - but for
cylinders that are used cur_pr[cyl] is initialized. But just to catch
errors elsewhere, let's not leave cur_pr[cyl] uninitialized.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
Diffstat (limited to 'profile.c')
-rw-r--r-- | profile.c | 5 |
1 files changed, 4 insertions, 1 deletions
@@ -585,8 +585,11 @@ static void fill_missing_tank_pressures(struct dive *dive, struct plot_info *pi, dump_pr_track(track_pr); #endif for (cyl = 0; cyl < MAX_CYLINDERS; cyl++) { - if (!track_pr[cyl]) + if (!track_pr[cyl]) { + /* no segment where this cylinder is used */ + cur_pr[cyl] = -1; continue; + } fill_missing_segment_pressures(track_pr[cyl]); cur_pr[cyl] = track_pr[cyl]->start; } |