cleanup: use begin/endResetModel in ExtraDataModel

As we do in most other models, use begin/endResetModel() to
reset the model. This is distinctly less errorprone than
the add/removeRows() version as we don't have to check for
empty ranges, etc.

Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>

1 files changed, 5 insertions, 9 deletions

diff --git a/qt-models/divecomputerextradatamodel.cpp b/qt-models/divecomputerextradatamodel.cpp
index 815c6cd81..2b2710f95 100644
--- a/qt-models/divecomputerextradatamodel.cpp
+++ b/qt-models/divecomputerextradatamodel.cpp
@@ -13,10 +13,9 @@ ExtraDataModel::ExtraDataModel(QObject *parent) : CleanerTableModel(parent),
 
 void ExtraDataModel::clear()
 {
-	if (rows > 0) {
-		beginRemoveRows(QModelIndex(), 0, rows - 1);
-		endRemoveRows();
-	}
+	beginResetModel();
+	rows = 0;
+	endResetModel();
 }
 
 QVariant ExtraDataModel::data(const QModelIndex &index, int role) const
@@ -57,15 +56,12 @@ int ExtraDataModel::rowCount(const QModelIndex&) const
 
 void ExtraDataModel::updateDive()
 {
-	clear();
+	beginResetModel();
 	rows = 0;
 	struct extra_data *ed = get_dive_dc(&displayed_dive, dc_number)->extra_data;
 	while (ed) {
 		rows++;
 		ed = ed->next;
 	}
-	if (rows > 0) {
-		beginInsertRows(QModelIndex(), 0, rows - 1);
-		endInsertRows();
-	}
+	endResetModel();
 }