summaryrefslogtreecommitdiffstats
path: root/qt-models/divecomputermodel.h
diff options
context:
space:
mode:
authorGravatar Berthold Stoeger <bstoeger@mail.tuwien.ac.at>2020-10-03 11:18:42 +0200
committerGravatar Dirk Hohndel <dirk@hohndel.org>2020-10-03 10:53:26 -0700
commit5bc6f5d36c491b305f66a03c8400666ccda0b044 (patch)
tree05dc2aadb40aaede4501b393677e506d04d72aec /qt-models/divecomputermodel.h
parent90ca6353167071af57028975dc650cd027605372 (diff)
downloadsubsurface-5bc6f5d36c491b305f66a03c8400666ccda0b044.tar.gz
cleanup: make device code more consistent with core
We keep track of device, i.e. distinct dive computers with id in the core. The corresponding code stuck out like a sore thumb. Firstly, because it is C++. But more importantly, because it used inconsistent nameing conventions. Notably it defined a "DiveComputerNode" when this is something very different from "struct dive_computer", the latter being the dive-computer related data of a single dive. Since the whole thing is defined in "device.h" and the function to create such an entry is called "create_device_node", call the structure "device". Use snake_case for consistency with the other core structures. Moreover, call the collection of devices "device_table" in analogy with "dive_table", etc. Overall, this should make the core code more consistent style-wise. Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
Diffstat (limited to 'qt-models/divecomputermodel.h')
-rw-r--r--qt-models/divecomputermodel.h2
1 files changed, 1 insertions, 1 deletions
diff --git a/qt-models/divecomputermodel.h b/qt-models/divecomputermodel.h
index 8c2373695..ab352513c 100644
--- a/qt-models/divecomputermodel.h
+++ b/qt-models/divecomputermodel.h
@@ -26,7 +26,7 @@ slots:
void remove(const QModelIndex &index);
private:
- QVector<DiveComputerNode> dcs;
+ QVector<device> dcs;
};
#endif