summaryrefslogtreecommitdiffstats
path: root/qt-models/divepicturemodel.h
diff options
context:
space:
mode:
authorGravatar Berthold Stoeger <bstoeger@mail.tuwien.ac.at>2018-05-19 21:18:39 +0200
committerGravatar Lubomir I. Ivanov <neolit123@gmail.com>2018-05-21 22:17:28 +0300
commitf47f2773fd4de5bfbb8d90e5e00dc18e0c18e5bb (patch)
tree2735961e5d272b79ce8ff81b8d6fd2197d00026b /qt-models/divepicturemodel.h
parent3c0c1801cd869f7a98c23356ab2ae4e373f55f31 (diff)
downloadsubsurface-f47f2773fd4de5bfbb8d90e5e00dc18e0c18e5bb.tar.gz
Dive pictures: don't repopulate DivePictureModel on deletion
On deletion of a single or multiple pictures, the whole DivePictureModel was repopulated, which was clearly visible in the UI, owing to the reconstructing of all images in the profile plot. To avoid this vexing behavior, implement proper deletion routines in DivePictureModel and ProfileWidget2. Since this needs sensible erase() semantics the QList<PictureEntry> member of DivePictureModel was replaced by a QVector. A QVector should be the default anyway, unless there are very specific reasons to use a QList (which actually is a deque, not a classical linked list). Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
Diffstat (limited to 'qt-models/divepicturemodel.h')
-rw-r--r--qt-models/divepicturemodel.h2
1 files changed, 1 insertions, 1 deletions
diff --git a/qt-models/divepicturemodel.h b/qt-models/divepicturemodel.h
index 61eb1d984..a7a3d7180 100644
--- a/qt-models/divepicturemodel.h
+++ b/qt-models/divepicturemodel.h
@@ -30,7 +30,7 @@ public slots:
void updateThumbnail(QString filename, QImage thumbnail);
private:
DivePictureModel();
- QList<PictureEntry> pictures;
+ QVector<PictureEntry> pictures;
int findPictureId(const QString &filename); // Return -1 if not found
double zoomLevel; // -1.0: minimum, 0.0: standard, 1.0: maximum
int size;