summaryrefslogtreecommitdiffstats
path: root/qt-models/divetripmodel.cpp
diff options
context:
space:
mode:
authorGravatar Berthold Stoeger <bstoeger@mail.tuwien.ac.at>2020-02-10 20:54:47 +0100
committerGravatar Dirk Hohndel <dirk@hohndel.org>2020-02-22 15:18:31 -0800
commitae5d2e6b4543d13bb432220c6cc06286085623ad (patch)
tree2b849d9817e202c49636f5226f1b7e45902d0450 /qt-models/divetripmodel.cpp
parent77a1c7c1f40fd9c884c4f6323ed30c1516c93c71 (diff)
downloadsubsurface-ae5d2e6b4543d13bb432220c6cc06286085623ad.tar.gz
Cleanup: remove DiveTripModelBase::sendShownChangedSignals()
This was used by the old filtering code. This is not necessary anymore. Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
Diffstat (limited to 'qt-models/divetripmodel.cpp')
-rw-r--r--qt-models/divetripmodel.cpp40
1 files changed, 0 insertions, 40 deletions
diff --git a/qt-models/divetripmodel.cpp b/qt-models/divetripmodel.cpp
index f7b62bc79..33c087a5a 100644
--- a/qt-models/divetripmodel.cpp
+++ b/qt-models/divetripmodel.cpp
@@ -752,46 +752,6 @@ dive *DiveTripModelTree::diveOrNull(const QModelIndex &index) const
return tripOrDive(index).dive;
}
-// Send data changed signals blockwise. Which entries are changed is collected
-// in the first parameter "changed".
-void DiveTripModelBase::sendShownChangedSignals(const std::vector<char> &changed, quintptr parentIndex)
-{
- static const QVector<int> roles { SHOWN_ROLE };
- for (size_t i = 0; i < changed.size(); ++i) {
- // Find first and last block of changed items
- if (!changed[i])
- continue;
- size_t j;
- for (j = i + 1; j < changed.size() && changed[j]; ++j)
- ; // Pass
- dataChanged(createIndex(i, 0, parentIndex), createIndex(j - 1, 0, parentIndex), roles);
- i = j - 1;
- }
-}
-
-// Applying the filter to trip-items is a bit tricky:
-// We only want to send changed-signals if one of the dives remains visible.
-// Because if no dive remains visible, we'll simply send a signal on the parent trip,
-// which will then be hidden and all the dives will be hidden implicitly as well.
-// Thus, do this in two passes: collect changed dives and only if any dive is visible,
-// send the signals.
-bool DiveTripModelTree::calculateFilterForTrip(const std::vector<dive *> &dives, const DiveFilter *filter, quintptr parentIndex)
-{
- bool showTrip = false;
- std::vector<char> changed;
- changed.reserve(dives.size());
- for (dive *d: dives) {
- bool shown = filter->showDive(d);
- changed.push_back(filter_dive(d, shown));
- showTrip |= shown;
- }
-
- // If any dive is shown, send changed-signals
- if (showTrip)
- sendShownChangedSignals(changed, parentIndex);
- return showTrip;
-}
-
// The tree-version of the model wants to process the dives per trip.
// This template takes a vector of dives and calls a function batchwise for each trip.
template<typename Function>